Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicit Error classes #88

Merged
merged 1 commit into from
Jul 25, 2015
Merged

Explicit Error classes #88

merged 1 commit into from
Jul 25, 2015

Conversation

floatdrop
Copy link
Contributor

Replacement for nested-error-stacks.

  • All error messages now retained and additional properties added (like host and method).
  • code property now comes from internal errors of Node (with ECONNREFUSED and so on values) and HTTP status code stored in statusCode property.
  • pathname support dropped (since there is no such option in http.request).
  • statusMessage added.

@floatdrop
Copy link
Contributor Author

@sindresorhus @julien-f please review.

@floatdrop floatdrop mentioned this pull request Jul 24, 2015
Merged
@floatdrop
Explicit Error classes
11680b1 
Closes #83 and closes #86
floatdrop added a commit that referenced this pull request Jul 25, 2015
@floatdrop
Merge pull request #88 from floatdrop/new-errors
aba353f 
Explicit Error classes
@floatdrop floatdrop merged commit aba353f into sindresorhus:master Jul 25, 2015
@floatdrop floatdrop deleted the new-errors branch July 25, 2015 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@floatdrop