-
-
Notifications
You must be signed in to change notification settings - Fork 957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue when using both path
and query
options
#86
Comments
I thought this would do for if (opts.pathname) {
opts.path = opts.pathname;
} |
Yes but the issue is there https://github.com/sindresorhus/got/blob/master/index.js#L59 |
I should probably not use both |
@julien-f I'm really thinking about standalone module for parsing and normalization. |
This could be resolved, if we drop |
Current implementation works if using
pathname
but not withpath
.I think the URL object should be normalized as soon as possible to avoid conflicts between:
host
andhostname
path
andpathname
The text was updated successfully, but these errors were encountered: