Detect new Windows terminal #27
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd rather wait for microsoft/terminal#1040.
|
|
@sindresorhus sure, just wanted to create the PR to have it as a pending task. |
|
Some other terminals like VSCode may have Unicode support too. |
|
I'm gonna close this for now. Feel free to open a new PR when microsoft/terminal#1040 is resolved and shipping in a live version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new Windows terminal fully supports Unicode symbols, sadly there is no
proper way to identify it yet. microsoft/terminal#1040
exists to tackle this issue, in the meantime every terminal session has a unique
env variable
WT_SESSIONwhich can be used to detect the terminal type.If you are okay with this PR as it is, or if you want to wait until a proper
detection method is implemented, please let me know.