Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please allow other spinners on Windows #159

Closed
ffMathy opened this issue Nov 5, 2020 · 6 comments · Fixed by #167
Closed

Please allow other spinners on Windows #159

ffMathy opened this issue Nov 5, 2020 · 6 comments · Fixed by #167

Comments

@ffMathy
Copy link

ffMathy commented Nov 5, 2020

Often, CLIs etc are used via VS Code's terminal, or some other terminal that does have support. For instance, Windows Terminal.

@sindresorhus
Copy link
Owner

sindresorhus commented Nov 11, 2020

Sure, but we need to be able to reliably detect those terminals that do support it.

@ffMathy
Copy link
Author

ffMathy commented Nov 11, 2020

Gotcha - that makes sense.

@woacademy
Copy link

@sindresorhus could you elaborate on sindresorhus/figures#27 (comment)?

I'm aware of the open issue you linked, however, WT_SESSION was added for this reason - microsoft/terminal#897. Could we use that until the other issue is closed out at some (possible distant) point in the future?

@dsl101
Copy link
Contributor

dsl101 commented Jan 19, 2021

Or, just allow unicode: true in the options object, to force use of unicode. Caveat emptor, and all that? I created a PR which enables this on windows (in an appropriate terminal) to work with all spinners. Really only useful for local scripts, not those intended to be published though.

@dsl101
Copy link
Contributor

dsl101 commented Jan 19, 2021

Does this meet your requirements? I'd be happy to alter the PR... It looks like that issue you linked to is going to be around for a while.

@sindresorhus
Copy link
Owner

Yes, I'm ok with that, since it doesn't look like Windows Terminal will have proper detection anytime soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants