punycode/ is misflagged as requiring the node: prefix

[nbouvrette]

import { encode as punycodeEncode } from 'punycode/'

Is reporting:

Prefer `node:punycode/` over `punycode/`.eslint[unicorn/prefer-node-protocol](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/v44.0.0/docs/rules/prefer-node-protocol.md)

When in fact, node:punycode is deprecated and punycode/ is a npm package.

[fisker]

sindresorhus/is-builtin-module#7

[silverwind]

I think to fix this, the rule could just ignore the import if the specifier ends in /, which in itself seems to be some kind of hack specific to node's module loader (I would not recommend using that, as it's bound to cause issues in other loaders).

[silverwind]

The hack with punycode/ does not work in node ESM, it only works in CJS, so I suggest to only support it for CJS, if at all. Better alternatives include either using punycode/punycode.js or the punycode.js npm module.

> await import("punycode/")
Uncaught:
Error [ERR_UNSUPPORTED_DIR_IMPORT]

I also opened mathiasbynens/punycode.js#122 for the punycode authors to update their suggestions.

[kachkaev]

Same here with import { Buffer } from "buffer/" being converted to import { Buffer } from "node:buffer/".

I tried import { Buffer } from "buffer/index.js" but it got converted to import { Buffer } from "node:buffer/index.js" too.

[fisker]

Fixed by #2060