prefer-node-protocol: Don't suggest node: prefix for punycode

Fixes: sindresorhus#1931
silverwind · Dec 15, 2022 · c4778bd · c4778bd
1 parent 23d0326
commit c4778bd
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/rules/prefer-node-protocol.js b/rules/prefer-node-protocol.js
@@ -26,6 +26,7 @@ const create = () => ({
 			typeof value !== 'string'
 			|| value.startsWith('node:')
 			|| !isBuiltinModule(value)
+			|| value == 'punycode'
 		) {
 			return;
 		}

diff --git a/test/prefer-node-protocol.mjs b/test/prefer-node-protocol.mjs
@@ -9,6 +9,7 @@ test.snapshot({
 		'import fs from "./fs";',
 		'import fs from "unknown-builtin-module";',
 		'import fs from "node:fs";',
+		'import punycode from "punycode";',
 		outdent`
 			async function foo() {
 				const fs = await import(fs);
@@ -74,6 +75,7 @@ test.snapshot({
 		'const fs = require();',
 		'const fs = require(...["fs"]);',
 		'const fs = require("unicorn");',
+		'const fs = require("punycode");',
 	],
 	invalid: [
 		'const {promises} = require("fs")',