Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Open Source Games #2171

Merged
merged 2 commits into from
Sep 27, 2022
Merged

Add Open Source Games #2171

merged 2 commits into from
Sep 27, 2022

Conversation

michelpereira
Copy link
Contributor

@michelpereira michelpereira commented Feb 5, 2022

https://github.com/michelpereira/awesome-open-source-games

The purpose of this is to keep a list of Open Source Games that are hosted on GitHub, so the others can fork and learn more about gaming.

Fixes #1198

By submitting this pull request I confirm I've read and complied with the below requirements 🖖

Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.

Requirements for your pull request

  • Don't waste my time. Do a good job, adhere to all the guidelines, and be responsive.
  • You have to review at least 2 other open pull requests.
    Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration. Just commenting “looks good” or simply marking the pull request as approved does not count! You have to actually point out mistakes or improvement suggestions.
  • You have read and understood the instructions for creating a list.
  • This pull request has a title in the format Add Name of List.
    • Add Swift
    • Add Software Architecture
    • Update readme.md
    • Add Awesome Swift
    • Add swift
    • add Swift
    • Adding Swift
    • Added Swift
  • Your entry here should include a short description about the project/theme of the list. It should not describe the list itself. The first character should be uppercase and the description should end in a dot. It should be an objective description and not a tagline or marketing blurb.
    • - [iOS](…) - Mobile operating system for Apple phones and tablets.
    • - [Framer](…) - Prototyping interactive UI designs.
    • - [iOS](…) - Resources and tools for iOS development.
    • - [Framer](…)
    • - [Framer](…) - prototyping interactive UI designs
  • Your entry should be added at the bottom of the appropriate category.
  • The suggested Awesome list complies with the below requirements.

Requirements for your Awesome list

  • Has been around for at least 30 days.
    That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
  • Don't open a Draft / WIP pull request while you work on the guidelines. A pull request should be 100% ready and should adhere to all the guidelines when you open it.
  • Run awesome-lint on your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it.
  • The default branch should be named main, not master.
  • Includes a succinct description of the project/theme at the top of the readme. (Example)
    • Mobile operating system for Apple phones and tablets.
    • Prototyping interactive UI designs.
    • Resources and tools for iOS development.
    • Awesome Framer packages and tools.
  • It's the result of hard work and the best I could possibly produce.
    If you have not put in considerable effort into your list, your pull request will be immediately closed.
  • The repo name of your list should be in lowercase slug format: awesome-name-of-list.
    • awesome-swift
    • awesome-web-typography
    • awesome-Swift
    • AwesomeWebTypography
  • The heading title of your list should be in title case format: # Awesome Name of List.
    • # Awesome Swift
    • # Awesome Web Typography
    • # awesome-swift
    • # AwesomeSwift
  • Non-generated Markdown file in a GitHub repo.
  • The repo should have awesome-list & awesome as GitHub topics. I encourage you to add more relevant topics.
  • Not a duplicate. Please search for existing submissions.
  • Only has awesome items. Awesome lists are curations of the best, not everything.
  • Does not contain items that are unmaintained, has archived repo, deprecated, or missing docs. If you really need to include such items, they should be in a separate Markdown file.
  • Includes a project logo/illustration whenever possible.
    • Either centered, fullwidth, or placed at the top-right of the readme. (Example)
    • The image should link to the project website or any relevant website.
    • The image should be high-DPI. Set it to maximum half the width of the original image.
  • Entries have a description, unless the title is descriptive enough by itself. It rarely is though.
  • Includes the Awesome badge.
    • Should be placed on the right side of the readme heading.
      • Can be placed centered if the list has a centered graphics header.
    • Should link back to this list.
  • Has a Table of Contents section.
    • Should be named Contents, not Table of Contents.
    • Should be the first section in the list.
    • Should only have one level of nested lists, preferably none.
    • Must not feature Contributing or Footnotes sections.
  • Has an appropriate license.
    • We strongly recommend the CC0 license, but any Creative Commons license will work.
      • Tip: You can quickly add it to your repo by going to this URL: https://github.com/<user>/<repo>/community/license/new?branch=main&template=cc0-1.0 (replace <user> and <repo> accordingly).
    • A code license like MIT, BSD, Apache, GPL, etc, is not acceptable. Neither are WTFPL and Unlicense.
    • Place a file named license or LICENSE in the repo root with the license text.
    • Do not add the license name, text, or a Licence section to the readme. GitHub already shows the license name and link to the full text at the top of the repo.
    • To verify that you've read all the guidelines, please comment on your pull request with just the word unicorn.
  • Has contribution guidelines.
    • The file should be named contributing.md. Casing is up to you.
    • It can optionally be linked from the readme in a dedicated section titled Contributing, positioned at the top or bottom of the main content.
    • The section should not appear in the Table of Contents.
  • All non-important but necessary content (like extra copyright notices, hyperlinks to sources, pointers to expansive content, etc) should be grouped in a Footnotes section at the bottom of the readme. The section should not be present in the Table of Contents.
  • Has consistent formatting and proper spelling/grammar.
    • The link and description are separated by a dash.
      Example: - [AVA](…) - JavaScript test runner.
    • The description starts with an uppercase character and ends with a period.
    • Consistent and correct naming. For example, Node.js, not NodeJS or node.js.
  • Doesn't use hard-wrapping.
  • Doesn't include a Travis badge.
    You can still use Travis for list linting, but the badge has no value in the readme.
  • Doesn't include an Inspired by awesome-foo or Inspired by the Awesome project kinda link at the top of the readme. The Awesome badge is enough.

Go to the top and read it again.

@michelpereira
Copy link
Contributor Author

unicorn

@sindresorhus
Copy link
Owner

Open Source Games that have => Open source games that have

@sindresorhus
Copy link
Owner

Pond - A narrow fellow in the Pond.

This description says nothing about what the game is about. #2133 (comment)

readme.md Outdated Show resolved Hide resolved
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
@michelpereira
Copy link
Contributor Author

Hi, there. Here is the last update fixing the repository name and add a detailed Pond description:
michelpereira/awesome-open-source-games@3ce6070

@sindresorhus
Copy link
Owner

#2133 (comment) still applies.

@sindresorhus
Copy link
Owner

Hi, there. Here is the last update fixing the repository name and add a detailed Pond description:
michelpereira/awesome-open-source-games@3ce6070

Pound => Pong, and there title should not be in the description anyway.

@Karneades
Copy link
Contributor

Karneades commented Feb 14, 2022

Hi @michelpereira, cool list and will add some security open source games later on.

Improvements for your list:

  • Contribute should be removed from the Contents section (table of content).
  • Topic awesome is missing in the repo.

@michelpereira
Copy link
Contributor Author

Improvements for your list:

  • Contribute should be removed from the Contents section (table of content).
  • Topic awesome is missing in the repo.

Hi, @Karneades.

It's done, thanks for the notice.

@sindresorhus
Copy link
Owner

❯ awesome-lint 'https://github.com/michelpereira/awesome-open-source-games'
✖ Linting

  README.md:108:3
  ✖  104:60  Text "Javascript" should be written as "JavaScript"  remark-lint:awesome-spell-check
  ✖  108:3   https://github.com/hughsk/ludum-dare-27              remark-lint:double-link
  ✖  128:43  Text "Javascript" should be written as "JavaScript"  remark-lint:awesome-spell-check
  ✖  155:80  Text "Javascript" should be written as "JavaScript"  remark-lint:awesome-spell-check
  ✖  174:3   https://github.com/hughsk/ludum-dare-27              remark-lint:double-link

  5 errors

https://github.com/sindresorhus/awesome-lint

@michelpereira
Copy link
Contributor Author

michelpereira commented Jun 8, 2022

Hi, there. Please re-run.

I'm reviewing all the games and push slowly to the repository.

(base) michelpereira@KIDBookPro awesome-open-source-games % npx awesome-lint https://github.com/michelpereira/awesome-open-source-games
✔ Linting
(base) michelpereira@KIDBookPro awesome-open-source-games %

@notpresident35
Copy link
Contributor

notpresident35 commented Aug 14, 2022

Open source games that have the source code available on GitHub => Open source games, tools, and source code releases hosted on GitHub
Are the tools and frameworks included also open source, or used to create/compile/run the open source games? It's unclear why they are included at all - seems like most of these would be better off stored elsewhere. Also, guidelines say miscellaneous links should be stored under the Footnote header
Why is the list of companies using GitHub included? Despite using git for some features, most of these companies are not known for open source software. Feels like more of an ad for GitHub than a resource, especially right at the top.
Why does Chat Bots need an entire category to itself for one link? Feels like this could be reorganized to avoid this. Alternatively, collect more chat bots!
Also, some links have broken links to their games - first one I checked was "Kriegspiel" and that refused to load. Source is still valuable, but maybe denote broken web games somehow.

Copy link
Contributor

@notpresident35 notpresident35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(reviewed earlier, see above comment)

@Lissy93
Copy link

Lissy93 commented Aug 17, 2022

(reviewed earlier, see above comment)

@notpresident35 -
What is the point of adding an extra review, just to say you've reviewed?
It sends out notifications to contributors unnecessarily, and it's annoying.

@notpresident35
Copy link
Contributor

@Lissy93 Yes, since last time I just commented without counting it as a review. Apologies for the extra notification - I'm still new to using github

@sindresorhus
Copy link
Owner

alex-semenyuk pushed a commit to alex-semenyuk/awesome that referenced this pull request Feb 19, 2023
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fork Awesome Open Source Games?
5 participants