Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DOS #1917

Merged
merged 2 commits into from
Jan 31, 2021
Merged

Add DOS #1917

merged 2 commits into from
Jan 31, 2021

Conversation

balintkissdev
Copy link
Contributor

@balintkissdev balintkissdev commented Dec 9, 2020

https://github.com/balintkissdev/awesome-dos

Maintained for over a year, this list provides a collection of DOS-related articles, programming tutorials, Youtube videos and list of DOS games with their source code, making this a starting point for anyone who want to try out retro-programming for this nostalgic operating system.

Tried my best to adhere to the guidelines. Ran awesome-lint, however, I disabled checking for no-repeat-punctuation for a list entry, because the original article name contained three periods (...).

Reviewed #1868 and #1915.

Let me know what would you change in the content, organization or the format.

[Insert URL to the list here]

[Explain what this list is about and why it should be included here]

By submitting this pull request I confirm I've read and complied with the below requirements 🖖

Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.

Requirements for your pull request

  • Don't waste my time. Do a good job, adhere to all the guidelines, and be responsive.
  • You have to review at least 2 other open pull requests.
    Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration. Just commenting “looks good” or simply marking the pull request as approved does not count! You have to actually point out mistakes or improvement suggestions.
  • You have read and understood the instructions for creating a list.
  • This pull request has a title in the format Add Name of List.
    • Add Swift
    • Add Software Architecture
    • Update readme.md
    • Add Awesome Swift
    • Add swift
    • add Swift
    • Adding Swift
    • Added Swift
  • Your entry here should include a short description about the project/theme of the list. It should not describe the list itself. The first character should be uppercase and the description should end in a dot. It should be an objective description and not a tagline or marketing blurb.
    • - [iOS](…) - Mobile operating system for Apple phones and tablets.
    • - [Framer](…) - Prototyping interactive UI designs.
    • - [iOS](…) - Resources and tools for iOS development.
    • - [Framer](…)
    • - [Framer](…) - prototyping interactive UI designs
  • Your entry should be added at the bottom of the appropriate category.
  • The suggested Awesome list complies with the below requirements.

Requirements for your Awesome list

  • Has been around for at least 30 days.
    That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
  • Don't open a Draft / WIP pull request while you work on the guidelines. A pull request should be 100% ready and should adhere to all the guidelines when you open it.
  • Run awesome-lint on your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it.
  • The default branch should be named main, not master.
  • Includes a succinct description of the project/theme at the top of the readme. (Example)
    • Mobile operating system for Apple phones and tablets.
    • Prototyping interactive UI designs.
    • Resources and tools for iOS development.
    • Awesome Framer packages and tools.
  • It's the result of hard work and the best I could possibly produce.
    If you have not put in considerable effort into your list, your pull request will be immediately closed.
  • The repo name of your list should be in lowercase slug format: awesome-name-of-list.
    • awesome-swift
    • awesome-web-typography
    • awesome-Swift
    • AwesomeWebTypography
  • The heading title of your list should be in title case format: # Awesome Name of List.
    • # Awesome Swift
    • # Awesome Web Typography
    • # awesome-swift
    • # AwesomeSwift
  • Non-generated Markdown file in a GitHub repo.
  • The repo should have awesome-list & awesome as GitHub topics. I encourage you to add more relevant topics.
  • Not a duplicate. Please search for existing submissions.
  • Only has awesome items. Awesome lists are curations of the best, not everything.
  • Does not contain items that are unmaintained, has archived repo, deprecated, or missing docs. If you really need to include such items, they should be in a separate Markdown file.
  • Includes a project logo/illustration whenever possible.
    • Either centered, fullwidth, or placed at the top-right of the readme. (Example)
    • The image should link to the project website or any relevant website.
    • The image should be high-DPI. Set it to maximum half the width of the original image.
  • Entries have a description, unless the title is descriptive enough by itself. It rarely is though.
  • Includes the Awesome badge.
    • Should be placed on the right side of the readme heading.
      • Can be placed centered if the list has a centered graphics header.
    • Should link back to this list.
  • Has a Table of Contents section.
    • Should be named Contents, not Table of Contents.
    • Should be the first section in the list.
    • Should only have one level of nested lists, preferably none.
    • Must not feature Contributing or Footnotes sections.
  • Has an appropriate license.
    • We strongly recommend the CC0 license, but any Creative Commons license will work.
      • Tip: You can quickly add it to your repo by going to this URL: https://github.com/<user>/<repo>/community/license/new?branch=main&template=cc0-1.0 (replace <user> and <repo> accordingly).
    • A code license like MIT, BSD, Apache, GPL, etc, is not acceptable. Neither are WTFPL and Unlicense.
    • Place a file named license or LICENSE in the repo root with the license text.
    • Do not add the license name, text, or a Licence section to the readme. GitHub already shows the license name and link to the full text at the top of the repo.
    • To verify that you've read all the guidelines, please comment on your pull request with just the word unicorn.
  • Has contribution guidelines.
    • The file should be named contributing.md. Casing is up to you.
    • It can optionally be linked from the readme in a dedicated section titled Contributing, positioned at the top or bottom of the main content.
    • The section should not appear in the Table of Contents.
  • All non-important but necessary content (like extra copyright notices, hyperlinks to sources, pointers to expansive content, etc) should be grouped in a Footnotes section at the bottom of the readme. The section should not be present in the Table of Contents.
  • Has consistent formatting and proper spelling/grammar.
    • The link and description are separated by a dash.
      Example: - [AVA](…) - JavaScript test runner.
    • The description starts with an uppercase character and ends with a period.
    • Consistent and correct naming. For example, Node.js, not NodeJS or node.js.
  • Doesn't use hard-wrapping.
  • Doesn't include a Travis badge.
    You can still use Travis for list linting, but the badge has no value in the readme.
  • Doesn't include an Inspired by awesome-foo or Inspired by the Awesome project kinda link at the top of the readme. The Awesome badge is enough.

Go to the top and read it again.

Maintained for over a year, this list provides a collection of DOS-related articles, programming tutorials, Youtube videos and list of DOS games with their source code, making this a starting point for anyone who want to try out retro-programming for this nostalgic operating system.

Ran `awesome-lint`, however, I disabled checking for `no-repeat-punctuation` for a list entry, because the original article name contained three periods (`...`).

Reviewed sindresorhus#1868 and sindresorhus#1915.

Let me know what would you change in the content, organization or the format.
@balintkissdev
Copy link
Contributor Author

unicorn

@Jogai
Copy link

Jogai commented Dec 10, 2020

Looks awesome!

You didnt follow the PR template to the letter (this repo has a really strict policy), the url to the list is missing.

Also, on the repo the link to 'sopwith' is broken.

@balintkissdev
Copy link
Contributor Author

balintkissdev commented Dec 11, 2020

@Jogai Thank you for your review!

You didnt follow the PR template to the letter (this repo has a really strict policy), the url to the list is missing.

Updated PR description.

Also, on the repo the link to 'sopwith' is broken.

Updated it with Wayback Machine link, and also found another resource where the source code was analyzed, so I included that too. Another issue was the hotlink protection on www.classicdosgames.com that prevented others from downloading sources for Cyberdogs, Abuse and Beneath a Steel Sky. I changed links to old websites into Wayback Machine links, and also set up awesome_bot for CI (balintkissdev/awesome-dos@4170489).

@balintkissdev
Copy link
Contributor Author

balintkissdev commented Jan 16, 2021

Updated by removing line mentioning that the list was generated from a template (balintkissdev/awesome-dos@599beee).

@sindresorhus
Copy link
Owner

Entries have a description, unless the title is descriptive enough by itself. It rarely is though.

readme.md Outdated Show resolved Hide resolved
@n2cholas
Copy link
Contributor

Nice awesome list! I could not find issues in terms of the guidelines. Here are my suggestions for the list:

  1. Would be nice to include a brief description of the games in the games section (e.g. "Homebrew games with source code") to give readers an idea of what they're clicking into.
  2. Since some sections only have one item, it may be useful to consolidate them into one header instead of separate headers.

@n2cholas n2cholas mentioned this pull request Jan 23, 2021
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
@balintkissdev
Copy link
Contributor Author

@sindresorhus @n2cholas

Added descriptions to all entries (including the games too).

Since some sections only have one item, it may be useful to consolidate them into one header instead of separate headers.

The only place where I found this appropriate was merging "DOS compilers" and "Development IDEs" into "Development tools".

balintkissdev/awesome-dos@1ccaad3

@sindresorhus sindresorhus merged commit efc2a48 into sindresorhus:main Jan 31, 2021
@sindresorhus
Copy link
Owner

Tweet: https://twitter.com/awesome__re/status/1355813614469271555

make-github-pseudonymous-again added a commit to aureooms-contrib/awesome that referenced this pull request Feb 24, 2021
* upstream/main:
  Meta tweaks
  Add DOS (sindresorhus#1917)
  Update readme.md
  Fix a link
  Update a link
  Add Games of Coding (sindresorhus#1933)
  Add Design Systems (sindresorhus#1876)
  Minor tweaks
  Add Veganism (sindresorhus#1886)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants