Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Web Monetization #1812

Merged
merged 3 commits into from
Dec 19, 2020
Merged

Add Web Monetization #1812

merged 3 commits into from
Dec 19, 2020

Conversation

thomasbnt
Copy link
Contributor

Awesome Web Monetization repository

Web Monetization is becoming more and more used on the Internet. It would be interesting for people to turn to a new payment method for websites such as blogs, videos, newsletters or shared photos whether it is monetized according to the time spent reading/watching. And all this natively on your computer.


Checked PR's:

#1800
#1811
#1795

By submitting this pull request I confirm I've read and complied with the below requirements 🖖

Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.

Requirements for your pull request

  • Don't waste my time. Do a good job, adhere to all the guidelines, and be responsive.
  • You have to review at least 2 other open pull requests.
    Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration.
  • You have read and understood the instructions for creating a list.
  • This pull request has a title in the format Add Name of List.
    • Add Swift
    • Add Software Architecture
    • Update readme.md
    • Add Awesome Swift
    • Add swift
    • Adding Swift
    • Added Swift
  • Your entry here should include a short description about the project/theme of the list. It should not describe the list itself. The first character should be uppercase and the description should end in a dot. It should be an objective description and not a tagline or marketing blurb.
    • - [iOS](…) - Mobile operating system for Apple phones and tablets.
    • - [Framer](…) - Prototyping interactive UI designs.
    • - [iOS](…) - Resources and tools for iOS development.
    • - [Framer](…)
    • - [Framer](…) - prototyping interactive UI designs
  • Your entry should be added at the bottom of the appropriate category.
  • The suggested Awesome list complies with the below requirements.

Requirements for your Awesome list

  • Has been around for at least 30 days.
    That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
  • Don't open a Draft / WIP pull request while you work on the guidelines. A pull request should be 100% ready and should adhere to all the guidelines when you open it.
  • Run awesome-lint on your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it.
  • The default branch should be named main, not master.
  • Includes a succinct description of the project/theme at the top of the readme. (Example)
    • Mobile operating system for Apple phones and tablets.
    • Prototyping interactive UI designs.
    • Resources and tools for iOS development.
    • Awesome Framer packages and tools.
  • It's the result of hard work and the best I could possibly produce.
    If you have not put in considerable effort into your list, your pull request will be immediately closed.
  • The repo name of your list should be in lowercase slug format: awesome-name-of-list.
    • awesome-swift
    • awesome-web-typography
    • awesome-Swift
    • AwesomeWebTypography
  • The heading title of your list should be in title case format: # Awesome Name of List.
    • # Awesome Swift
    • # Awesome Web Typography
    • # awesome-swift
    • # AwesomeSwift
  • Non-generated Markdown file in a GitHub repo.
  • The repo should have awesome-list & awesome as GitHub topics. I encourage you to add more relevant topics.
  • Not a duplicate. Please search for existing submissions.
  • Only has awesome items. Awesome lists are curations of the best, not everything.
  • Does not contain items that are unmaintained, has archived repo, deprecated, or missing docs. If you really need to include such items, they should be in a separate Markdown file.
  • Includes a project logo/illustration whenever possible.
    • Either centered, fullwidth, or placed at the top-right of the readme. (Example)
    • The image should link to the project website or any relevant website.
    • The image should be high-DPI. Set it to maximum half the width of the original image.
  • Entries have a description, unless the title is descriptive enough by itself. It rarely is though.
  • Includes the Awesome badge.
    • Should be placed on the right side of the readme heading.
      • Can be placed centered if the list has a centered graphics header.
    • Should link back to this list.
  • Has a Table of Contents section.
    • Should be named Contents, not Table of Contents.
    • Should be the first section in the list.
    • Should only have one level of nested lists, preferably none.
  • Has an appropriate license.
    • We strongly recommend the CC0 license, but any Creative Commons license will work.
      • Tip: You can quickly add it to your repo by going to this URL: https://github.com/<user>/<repo>/community/license/new?branch=master&template=cc0-1.0 (replace <user> and <repo> accordingly).
    • A code license like MIT, BSD, Apache, GPL, etc, is not acceptable. Neither are WTFPL and Unlicense.
    • Place a file named license or LICENSE in the repo root with the license text.
    • Do not add the license name or text to the readme. GitHub already shows the license name at the top of the repo.
    • To verify that you've read all the guidelines, please comment on your pull request with just the word unicorn.
  • Has contribution guidelines.
    • The file should be named contributing.md. Casing is up to you.
  • Has consistent formatting and proper spelling/grammar.
    • The link and description are separated by a dash.
      Example: - [AVA](…) - JavaScript test runner.
    • The description starts with an uppercase character and ends with a period.
    • Consistent and correct naming. For example, Node.js, not NodeJS or node.js.
  • Doesn't include a Travis badge.
    You can still use Travis for list linting, but the badge has no value in the readme.
  • Doesn't include an Inspired by awesome-foo or Inspired by the Awesome project kinda link at the top of the readme. The Awesome badge is enough.

Go to the top and read it again.

@thomasbnt
Copy link
Contributor Author

Oh and, unicorn ! 🦄

@thomasbnt
Copy link
Contributor Author

Linked to this issue thomasbnt/awesome-web-monetization#4

Copy link
Contributor

@mhxion mhxion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requirements no. 4 indicates to rename/move the default branch from master to main.

  • The default branch should be named main, not master.

You can follow the steps here on how to rename this.

readme.md Outdated
@@ -654,6 +654,7 @@
- [Prometheus](https://github.com/roaldnefs/awesome-prometheus#readme) - Open-source monitoring system.
- [Homematic](https://github.com/homematic-community/awesome-homematic#readme) - Smart home devices.
- [Ledger](https://github.com/sfischer13/awesome-ledger#readme) - Double-entry accounting on the command-line.
- [Web Monetization](https://github.com/thomasbnt/awesome-web-monetization) - Web service that allows you to send money directly in your browser.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not make it clear that it's an open standard. It makes it sound like it's a paid API.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edited with f078080 (#1812)

@sindresorhus
Copy link
Owner

Thanks for making an Awesome list! 🙌

It looks like you didn't read the guidelines closely enough. I noticed multiple things that are not followed. Try going through the list point for point to ensure you follow it. I spent a lot of time creating the guidelines so I wouldn't have to comment on common mistakes, and rather spend my time improving Awesome.

@thomasbnt
Copy link
Contributor Author

Requirements no. 4 indicates to rename/move the default branch from master to main.

  • The default branch should be named main, not master.

You can follow the steps here on how to rename this.

Ooops yeah I forgotten that on my repository

@sindresorhus
Copy link
Owner

7acb34c

@Potherca
Copy link

@sindresorhus We ran the Awesome Linter, which passed... Is there anything that could be added there to make the issues we have here more clear? If yes (as I know you are very bussssssy), I don't mind doing the work to put 'm in...

@thomasbnt
Copy link
Contributor Author

@mhxion Thanks for the post to edit that. The default branch is main now!

@thomasbnt
Copy link
Contributor Author

thomasbnt commented Jun 27, 2020

7acb34c

Checked again the repositories, no errors for #1800 and #1795.

Why do you not add a GitHub Action with awesome-lint and require to news Awesome repositories to use that before Pr's here and put that as a requirement ? For you, less time lost 🦄

@mhxion mhxion mentioned this pull request Jun 28, 2020
Copy link
Contributor

@mhxion mhxion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thomasbnt From the requirements:

Do not add the license name or text to the readme. GitHub already shows the license name at the top of the repo.

You need to remove the license section.

@thomasbnt
Copy link
Contributor Author

thomasbnt commented Jun 28, 2020

@thomasbnt From the requirements:

Do not add the license name or text to the readme. GitHub already shows the license name at the top of the repo.

You need to remove the license section.

Checked

@thomasbnt
Copy link
Contributor Author

Your repository on Discord presentation is very cool ! Good job, and nice with badges !

Copy link
Contributor

@mhxion mhxion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thomasbnt Thanks (:
I just noticed one other thing.

Has consistent formatting and proper spelling/grammar.

  • The link and description are separated by a dash.
  • Example: - [AVA](…) - JavaScript test runner.

Your entry descriptions are wrapped inside links too, you need to keep the description in plaintext.

@thomasbnt
Copy link
Contributor Author

@mhxion all is good ! Check with awesome lint for the repository. No more errors

@mhxion
Copy link
Contributor

mhxion commented Jun 29, 2020

@thomasbnt I did run awesome-lint, no error as well. I don't know why awesome-lint didn't validate that, based on the requirement instead of

- [svelte-monetization : A minimal and lightweight wrapper for the Web Monetization API](https://github.com/sorxrob/svelte-monetization) ![](assets/small_icons/svelte.png)

it needs to be

- [svelte-monetization](https://github.com/sorxrob/svelte-monetization) : A minimal and lightweight wrapper for the Web Monetization API ![](assets/small_icons/svelte.png)

I guess @sindresorhus can verify this issue here if this isn't a strict requirement at all.

@thomasbnt
Copy link
Contributor Author

thomasbnt commented Jun 29, 2020

Waiting @sindresorhus for answer that, yeep. But could be more accessible to link title and description of the resource, not just the title 😃

@sindresorhus
Copy link
Owner

The guidelines are the source of truth. The linter doesn't catch everything.

@thomasbnt
Copy link
Contributor Author

The guidelines are the source of truth. The linter doesn't catch everything.

Okay it's edited!
🐙 thomasbnt/awesome-web-monetization@9a5611a

@sindresorhus
Copy link
Owner

There are still multiple things not follow from the guidelines. Please read through each item thoroughly.

@thomasbnt
Copy link
Contributor Author

thomasbnt commented Jul 3, 2020

I've got an error but..

readme.md:105:151 ~✖ 105:151 List item description must end with proper punctuation remark-lint:awesome-list-item

there are that :

- [Monetization](https://github.com/KNawm/monetization) - A wrapper around the Web Monetization API to monetize apps. ![](assets/small_icons/dart.png) 

Why the asset could block and display this error knowing that for other resources no error is present?

Latest build passed with no errors!

readme.md Outdated Show resolved Hide resolved
@sindresorhus
Copy link
Owner

Includes a succinct description of the project/theme at the top of the readme. (Example)
✅ Mobile operating system for Apple phones and tablets.
✅ Prototyping interactive UI designs.
❌ Resources and tools for iOS development.
❌ Awesome Framer packages and tools.

Not done.

The following is not good enough:

Web Monetization is a web service that allows you to send money directly in your browser. — If you want you know more, see :

And the description should be above the "Contents" section.


Everything under the Resources section, could be top-level sections.


Don't include empty sections.


There's very little content in the list.

thomasbnt added a commit to thomasbnt/awesome-web-monetization that referenced this pull request Aug 20, 2020
@sindresorhus
Copy link
Owner

Bump

@thomasbnt
Copy link
Contributor Author

Hello ! All is good, but you say there is little content at the moment. I prefer not to relaunch for the moment. a few changes have been made, contributors have played the game.💪🏼

@sindresorhus sindresorhus merged commit 1b8e590 into sindresorhus:main Dec 19, 2020
@sindresorhus
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants