-
-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Web Monetization #1812
Add Web Monetization #1812
Conversation
Oh and, unicorn ! 🦄 |
Linked to this issue thomasbnt/awesome-web-monetization#4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requirements no. 4 indicates to rename/move the default branch from master
to main
.
- The default branch should be named main, not master.
You can follow the steps here on how to rename this.
readme.md
Outdated
@@ -654,6 +654,7 @@ | |||
- [Prometheus](https://github.com/roaldnefs/awesome-prometheus#readme) - Open-source monitoring system. | |||
- [Homematic](https://github.com/homematic-community/awesome-homematic#readme) - Smart home devices. | |||
- [Ledger](https://github.com/sfischer13/awesome-ledger#readme) - Double-entry accounting on the command-line. | |||
- [Web Monetization](https://github.com/thomasbnt/awesome-web-monetization) - Web service that allows you to send money directly in your browser. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not make it clear that it's an open standard. It makes it sound like it's a paid API.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Edited with f078080
(#1812)
Thanks for making an Awesome list! 🙌 It looks like you didn't read the guidelines closely enough. I noticed multiple things that are not followed. Try going through the list point for point to ensure you follow it. I spent a lot of time creating the guidelines so I wouldn't have to comment on common mistakes, and rather spend my time improving Awesome. |
Ooops yeah I forgotten that on my repository |
@sindresorhus We ran the Awesome Linter, which passed... Is there anything that could be added there to make the issues we have here more clear? If yes (as I know you are very bussssssy), I don't mind doing the work to put 'm in... |
@mhxion Thanks for the post to edit that. The default branch is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thomasbnt From the requirements:
Do not add the license name or text to the readme. GitHub already shows the license name at the top of the repo.
You need to remove the license section.
Checked |
Your repository on Discord presentation is very cool ! Good job, and nice with badges ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thomasbnt Thanks (:
I just noticed one other thing.
Has consistent formatting and proper spelling/grammar.
- The link and description are separated by a dash.
- Example: -
[AVA](…) - JavaScript test runner.
Your entry descriptions are wrapped inside links too, you need to keep the description in plaintext.
@mhxion all is good ! Check with awesome lint for the repository. No more errors |
@thomasbnt I did run - [svelte-monetization : A minimal and lightweight wrapper for the Web Monetization API](https://github.com/sorxrob/svelte-monetization) ![](assets/small_icons/svelte.png) it needs to be - [svelte-monetization](https://github.com/sorxrob/svelte-monetization) : A minimal and lightweight wrapper for the Web Monetization API ![](assets/small_icons/svelte.png) I guess @sindresorhus can verify this issue here if this isn't a strict requirement at all. |
Waiting @sindresorhus for answer that, yeep. But could be more accessible to link title and description of the resource, not just the title 😃 |
The guidelines are the source of truth. The linter doesn't catch everything. |
Okay it's edited! |
There are still multiple things not follow from the guidelines. Please read through each item thoroughly. |
- [Monetization](https://github.com/KNawm/monetization) - A wrapper around the Web Monetization API to monetize apps. ![](assets/small_icons/dart.png)
|
Not done. The following is not good enough:
And the description should be above the "Contents" section. Everything under the Don't include empty sections. There's very little content in the list. |
About this PR : sindresorhus/awesome/pull/1812
Bump |
Hello ! All is good, but you say there is little content at the moment. I prefer not to relaunch for the moment. a few changes have been made, contributors have played the game.💪🏼 |
Awesome Web Monetization repository
Web Monetization is becoming more and more used on the Internet. It would be interesting for people to turn to a new payment method for websites such as blogs, videos, newsletters or shared photos whether it is monetized according to the time spent reading/watching. And all this natively on your computer.
Checked PR's:
#1800
#1811
#1795
By submitting this pull request I confirm I've read and complied with the below requirements 🖖
Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.
Requirements for your pull request
Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration.
Add Name of List
.Add Swift
Add Software Architecture
Update readme.md
Add Awesome Swift
Add swift
Adding Swift
Added Swift
- [iOS](…) - Mobile operating system for Apple phones and tablets.
- [Framer](…) - Prototyping interactive UI designs.
- [iOS](…) - Resources and tools for iOS development.
- [Framer](…)
- [Framer](…) - prototyping interactive UI designs
Requirements for your Awesome list
That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
awesome-lint
on your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it.main
, notmaster
.Mobile operating system for Apple phones and tablets.
Prototyping interactive UI designs.
Resources and tools for iOS development.
Awesome Framer packages and tools.
If you have not put in considerable effort into your list, your pull request will be immediately closed.
awesome-name-of-list
.awesome-swift
awesome-web-typography
awesome-Swift
AwesomeWebTypography
# Awesome Name of List
.# Awesome Swift
# Awesome Web Typography
# awesome-swift
# AwesomeSwift
awesome-list
&awesome
as GitHub topics. I encourage you to add more relevant topics.Contents
, notTable of Contents
.https://github.com/<user>/<repo>/community/license/new?branch=master&template=cc0-1.0
(replace<user>
and<repo>
accordingly).license
orLICENSE
in the repo root with the license text.unicorn
.contributing.md
. Casing is up to you.Example:
- [AVA](…) - JavaScript test runner.
Node.js
, notNodeJS
ornode.js
.You can still use Travis for list linting, but the badge has no value in the readme.
Inspired by awesome-foo
orInspired by the Awesome project
kinda link at the top of the readme. The Awesome badge is enough.Go to the top and read it again.