-
-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FastAPI #1800
Add FastAPI #1800
Conversation
unicorn |
The header looks a bit messy with both the logo and the "Awesome FastAPI" title. Either move the logo to the right and make it smaller, or create an image that has the "Awesome" wording above the FastAPI logo and then drop the text heading (many lists do this). |
|
Some entries are missing a description. |
Typescript => TypeScript |
LGTM. No linter errors. On the top 'Share on Twitter' without image, but maybe it's deliberate action. |
Are you saying that all entries need a description? From the guide it looked like this was subjective and up to me - |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but delete Share on Twitter
😄
And no errors with awesome-lint.
All items, unless the title is descriptive enough, which it rarely is. |
Updates:
Commit: mjhea0/awesome-fastapi@406f45a |
#1800 (comment) is not done. |
"Includes a succinct description of the project/theme at the top of the readme. (Example)"
|
The description should describe what FastAPI is, not what the list contains. |
It's a copy-paste from: https://github.com/sindresorhus/awesome/blob/main/pull_request_template.md The link is there. |
Just updated with: FastAPI is a modern, high-performance, batteries-included Python web framework that's perfect for building RESTful APIs. |
https://github.com/mjhea0/awesome-fastapi
The list is about FastAPI, a Python-based, async web application framework. It should be included since (1) the isn't already a FastAPI awesome list and (2) FastAPI is a popular framework for Python web app development.
By submitting this pull request I confirm I've read and complied with the below requirements 🖖