Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FastAPI #1800

Merged
merged 1 commit into from
Jul 3, 2020
Merged

Add FastAPI #1800

merged 1 commit into from
Jul 3, 2020

Conversation

mjhea0
Copy link
Contributor

@mjhea0 mjhea0 commented Jun 15, 2020

https://github.com/mjhea0/awesome-fastapi

The list is about FastAPI, a Python-based, async web application framework. It should be included since (1) the isn't already a FastAPI awesome list and (2) FastAPI is a popular framework for Python web app development.

By submitting this pull request I confirm I've read and complied with the below requirements 🖖

@mjhea0
Copy link
Contributor Author

mjhea0 commented Jun 15, 2020

@mjhea0
Copy link
Contributor Author

mjhea0 commented Jun 15, 2020

unicorn

@mjhea0
Copy link
Contributor Author

mjhea0 commented Jun 15, 2020

@sindresorhus
Copy link
Owner

The header looks a bit messy with both the logo and the "Awesome FastAPI" title. Either move the logo to the right and make it smaller, or create an image that has the "Awesome" wording above the FastAPI logo and then drop the text heading (many lists do this).

@sindresorhus
Copy link
Owner

Includes a succinct description of the project/theme at the top of the readme. (Example)

@sindresorhus
Copy link
Owner

Some entries are missing a description.

@sindresorhus
Copy link
Owner

Typescript => TypeScript

@coderbm1
Copy link

LGTM. No linter errors. On the top 'Share on Twitter' without image, but maybe it's deliberate action.

@coderbm1 coderbm1 mentioned this pull request Jun 22, 2020
@mjhea0
Copy link
Contributor Author

mjhea0 commented Jun 22, 2020

Some entries are missing a description.

Are you saying that all entries need a description? From the guide it looked like this was subjective and up to me - Entries have a description, unless the title is descriptive enough by itself. Is that note the case? If not, I can add descriptions.

Copy link
Contributor

@thomasbnt thomasbnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but delete Share on Twitter 😄

And no errors with awesome-lint.

@thomasbnt thomasbnt mentioned this pull request Jun 26, 2020
@sindresorhus
Copy link
Owner

Are you saying that all entries need a description? From the guide it looked like this was subjective and up to me - Entries have a description, unless the title is descriptive enough by itself. Is that note the case? If not, I can add descriptions.

All items, unless the title is descriptive enough, which it rarely is.

@mjhea0
Copy link
Contributor Author

mjhea0 commented Jul 1, 2020

Updates:

  1. Fixed the header (removed the 'share on twitter' link as well as the FastAPI image)
  2. Typescript => TypeScript
  3. Added descriptions to all relevant entries

Commit: mjhea0/awesome-fastapi@406f45a
CI Build: https://travis-ci.org/github/mjhea0/awesome-fastapi/builds/703907954

@sindresorhus
Copy link
Owner

#1800 (comment) is not done.

@mjhea0
Copy link
Contributor Author

mjhea0 commented Jul 3, 2020

#1800 (comment) is not done.

"Includes a succinct description of the project/theme at the top of the readme. (Example)"

  1. At the very top? Above the "Awesome FastAPI" title?
  2. Is "A curated list of awesome things related to FastAPI" not succinct enough?
  3. What does (Example) mean? Did you mean to add a link to an example?

@sindresorhus
Copy link
Owner

The description should describe what FastAPI is, not what the list contains.

@sindresorhus
Copy link
Owner

What does (Example) mean? Did you mean to add a link to an example?

It's a copy-paste from: https://github.com/sindresorhus/awesome/blob/main/pull_request_template.md The link is there.

@mjhea0
Copy link
Contributor Author

mjhea0 commented Jul 3, 2020

Just updated with:

FastAPI is a modern, high-performance, batteries-included Python web framework that's perfect for building RESTful APIs.

@sindresorhus sindresorhus merged commit 2317e48 into sindresorhus:main Jul 3, 2020
@sindresorhus
Copy link
Owner

sindresorhus commented Jul 3, 2020

DejanPerovic pushed a commit to DejanPerovic/awesome that referenced this pull request Jul 6, 2020
@mjhea0 mjhea0 deleted the patch-3 branch December 12, 2020 23:28
@mjhea0 mjhea0 mentioned this pull request Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants