-
-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Topological Data Analysis #1797
Conversation
unicorn 🦄 |
Please read through the guidelines again. There are many things that are not followed. |
@sindresorhusI fixed it. Now, awesome-lint hasn't any errors. |
LGTM - no linter errors. Only free suggestions - free lines (redundant 'enters', but looks also OK). And License info - referring to 'no licence info necessary into readme'. |
Thank you, but I do not agree. free lines don't look different in view, but it helps me. also I think it's better for someone who doesn't want to contribution to see the license without opening a new file. |
@@ -354,6 +354,7 @@ | |||
- [Search Engine Optimization](https://github.com/marcobiedermann/search-engine-optimization#readme) | |||
- [Competitive Programming](https://github.com/lnishan/awesome-competitive-programming#readme) | |||
- [Math](https://github.com/rossant/awesome-math#readme) | |||
- [Topological Data Analysis](https://github.com/FatemehTarashi/awesome-TDA) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your entry here should include a short description about the project/theme of the list. It should not describe the list itself. The first character should be uppercase and the description should end in a dot. It should be an objective description and not a tagline or marketing blurb.
You could go with "In applied mathematics, TDA is an approach to the analysis of datasets using techniques from topology." (which is already in the description in your readme).
unicorn |
@FatemehTarashi As mentioned in the guidelines,
please remove the license information from the bottom of your README. As per the guidelines, please run
Another point from the guideline which is not followed is,
|
An addition to the previous review comments: |
@Sid2697 Thanks for licence part. I run awesome-lint before and now and my repository doesn't have any error. |
Thanks for your response @FatemehTarashi. I was interpreting the guideline of "The default branch should be named |
There are still many things that are not followed:
And more. |
I'm going to close this for now as the list is not close to being added and there's no progress. I would recommend reading through the guidelines more closely, work more on the list, and try submitting again sometime in the future (after at least 3 months). |
This's #1703 closed pull request.
topological data analysis
(TDA) is an approach to the analysis of datasets using techniques from topology.
This list is handy for those who want to know more about TDA's theory and Tools in both mathematics and computer science.
PRs Reviewed:
#1701
#1684
#1792
By submitting this pull request I confirm I've read and complied with the below requirements 🖖
Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.
Requirements for your pull request
Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration.
Add Name of List
.Add Swift
Add Software Architecture
Update readme.md
Add Awesome Swift
Add swift
Adding Swift
Added Swift
- [iOS](…) - Mobile operating system for Apple phones and tablets.
- [Framer](…) - Prototyping interactive UI designs.
- [iOS](…) - Resources and tools for iOS development.
- [Framer](…)
- [Framer](…) - prototyping interactive UI designs
Requirements for your Awesome list
That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
awesome-lint
on your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it.main
, notmaster
.Mobile operating system for Apple phones and tablets.
Prototyping interactive UI designs.
Resources and tools for iOS development.
Awesome Framer packages and tools.
If you have not put in considerable effort into your list, your pull request will be immediately closed.
awesome-name-of-list
.awesome-swift
awesome-web-typography
awesome-Swift
AwesomeWebTypography
# Awesome Name of List
.# Awesome Swift
# Awesome Web Typography
# awesome-swift
# AwesomeSwift
awesome-list
&awesome
as GitHub topics. I encourage you to add more relevant topics.Contents
, notTable of Contents
.https://github.com/<user>/<repo>/community/license/new?branch=master&template=cc0-1.0
(replace<user>
and<repo>
accordingly).license
orLICENSE
in the repo root with the license text.unicorn
.contributing.md
. Casing is up to you.Example:
- [AVA](…) - JavaScript test runner.
Node.js
, notNodeJS
ornode.js
.You can still use Travis for list linting, but the badge has no value in the readme.
Inspired by awesome-foo
orInspired by the Awesome project
kinda link at the top of the readme. The Awesome badge is enough.Go to the top and read it again.