-
-
Notifications
You must be signed in to change notification settings - Fork 27.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add V #1684
Add V #1684
Conversation
Thanks for making an Awesome list! 🙌 It looks like you didn't read the guidelines closely enough. I noticed multiple things that are not followed. Try going through the list point for point to ensure you follow it. I spent a lot of time creating the guidelines so I wouldn't have to comment on common mistakes, and rather spend my time improving Awesome. |
You've created a substantial collection of resources, but you appear to be missing a bunch of items from the requirements list. Let's complete the quest:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update link to point out at the readme file, to make uniform with all the other across the list:
https://github.com/vlang/awesome-v#readme
Please check list items formatting:
Using awesome-lint may help you a lot. |
@aliesbelik Hi! Thanks for reviewing
Interesting that running |
@alexesprit sorry, that's my fault: because of incorrect ToC header anchors in list entries were treated as incorrect URLs ( |
Now @aliesbelik What do you think? Have we some missing things should be fixed? |
Looks fine to me. But to complete the quest please add at least 2 PRs you reviewed for this project. |
unicorn |
@alexesprit, I appreciate your efforts. Looking into the other PRs I can note that adding link to V's website for All the other points look good to me. |
@aliesbelik Good catch! I added the link to the V website. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Please use the default PR template of awesome project for your PR description, you can refer to #1688, see the description of this PR. |
@jetli done |
Looks good. 👍 |
Seems like this PR can be finally merged. |
Couldn't find anything wrong. Great awesome list! |
Can you merge it please? |
This PR should be rebased on to latest master to satisfy the guidelines:
Also, it breaks the Coq description - removes dot at the end of the description.
|
@medvednikov and @alexesprit done |
It's still not at the bottom of the list. |
@alexesprit now done? |
Can you merge please? |
Can anyone please merge this? |
Any plans to merge? |
V is a new programming language inspired from C, C++, Go and Python.
This list is very useful for those who want to know more about the language.
By submitting this pull request I confirm I've read and complied with the awesome list requirements 🖖
By submitting this pull request I confirm I've read and complied with the below requirements 🖖
Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.
Requirements for your pull request
Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration.
Add Name of List
.Add Swift
Add Software Architecture
Update readme.md
Add Awesome Swift
Add swift
Adding Swift
Added Swift
- [iOS](…) - Mobile operating system for Apple phones and tablets.
- [Framer](…) - Prototyping interactive UI designs.
- [iOS](…) - Resources and tools for iOS development.
- [Framer](…)
- [Framer](…) - prototyping interactive UI designs
Requirements for your Awesome list
That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
awesome-lint
on your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it.Mobile operating system for Apple phones and tablets.
Prototyping interactive UI designs.
Resources and tools for iOS development.
Awesome Framer packages and tools.
If you have not put in considerable effort into your list, your pull request will be immediately closed.
awesome-name-of-list
.awesome-swift
awesome-web-typography
awesome-Swift
AwesomeWebTypography
# Awesome Name of List
.# Awesome Swift
# Awesome Web Typography
# awesome-swift
# AwesomeSwift
awesome-list
&awesome
as GitHub topics. I encourage you to add more relevant topics.Contents
, notTable of Contents
.https://github.com/<user>/<repo>/community/license/new?branch=master&template=cc0-1.0
(replace<user>
and<repo>
accordingly).license
orLICENSE
in the repo root with the license text.unicorn
.contributing.md
. Casing is up to you.Example:
- [AVA](…) - JavaScript test runner.
Node.js
, notNodeJS
ornode.js
.You can still use Travis for list linting, but the badge has no value in the readme.
Inspired by awesome-foo
orInspired by the Awesome project
kinda link at the top of the readme. The Awesome badge is enough.Go to the top and read it again.