Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve colour palette of PlantUML graphs #180

Merged
merged 3 commits into from
Aug 9, 2021
Merged

Improve colour palette of PlantUML graphs #180

merged 3 commits into from
Aug 9, 2021

Conversation

create-issue-branch[bot]
Copy link
Contributor

closes #166

@pablo-de-andres pablo-de-andres marked this pull request as ready for review August 5, 2021 15:55
kysrpex
kysrpex approved these changes Aug 9, 2021
View reviewed changes
Copy link
Contributor

@kysrpex kysrpex left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not see the changes locally but I guess this is a problem I have with the local renderer. I'll just assume you made nice changes.

EDIT: If you actually want feedback, you can post a screenshot of the new style here.

@kysrpex kysrpex self-requested a review August 9, 2021 07:39
@kysrpex
Copy link
Contributor

kysrpex commented Aug 9, 2021

Sorry, wrong branch 😆, now I see the difference.

@pablo-de-andres
Copy link
Member

pablo-de-andres commented Aug 9, 2021 •
edited
Loading

I'd suggest merging to dev and temporarily activating the rendering of dev? It is activated already
That way we also make sure that it will work on the final platform

@pablo-de-andres pablo-de-andres merged commit e0b632c into dev Aug 9, 2021
kysrpex
kysrpex approved these changes Aug 9, 2021
View reviewed changes
Copy link
Contributor

@kysrpex kysrpex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely better, and a good match for the Sphinx theme we're using.

@kysrpex
Copy link
Contributor

kysrpex commented Aug 9, 2021

I'd suggest merging to dev and temporarily activating the rendering of dev? It is activated already
That way we also make sure that it will work on the final platform

Exactly https://simphony.readthedocs.io/en/dev/.

@kysrpex kysrpex deleted the 166-Improve_colour_palette_of_PlantUML_graphs branch August 9, 2021 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kysrpex kysrpex kysrpex approved these changes

@yoavnash yoavnash Awaiting requested review from yoavnash

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kysrpex @pablo-de-andres