-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove disabled extensions from allowed_extensions #439
Conversation
@@ -801,7 +801,7 @@ public function testRename() | |||
public function testGetAllowedExtensions($allowedExtensions, $expected) | |||
{ | |||
Config::modify()->set(File::class, 'allowed_extensions', $allowedExtensions); | |||
$this->assertSame($expected, $expected); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is one of the funnier things I've ever had to fix in a PR 😆
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙈
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good fix. This is probably worth putting into a patch release for order version. Can you retarget to the 1.7 branch?
Will do, just going to rebase 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!!! Merge on green.
Fixes #438
Currently the docs example doesn't work: https://docs.silverstripe.org/en/4/developer_guides/files/allowed_file_types/#file-extensions-validation
It just skips over the value and leaves the original in the list. This change removes it from the core list.