Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't remove entries from file allowed_extensions list #438

Closed
robingram opened this issue Mar 10, 2021 · 3 comments · Fixed by #439
Closed

Can't remove entries from file allowed_extensions list #438

robingram opened this issue Mar 10, 2021 · 3 comments · Fixed by #439

Comments

@robingram
Copy link

Using Silverstripe in 4.6.

The documented method here to remove existing entries from the allowed_extensions list does not work: https://docs.silverstripe.org/en/4/developer_guides/files/allowed_file_types/

If I add, say:

SilverStripe\Assets\File:
  allowed_extensions:
    zip: false

Looking at the code, all it does is skip that new entry for zip. It doesn't check if zip is already in the list and remove it.

If that is the intended behaviour then perhaps the docs need to be clarified.

@maxime-rainville
Copy link
Contributor

Fixed by #439

@jonners99
Copy link

Is this fix going to be in a tagged release soon?

@maxime-rainville
Copy link
Contributor

@jonners99 It's going to be included in the next 4.8 release which should ship early June-ish. If you need it right now, I can create a 1.7.x release of assets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants