Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC Update percentages for eagerloading benchmark #458

Conversation

GuySartorelli
Copy link
Member

Description

While working on silverstripe/silverstripe-framework#10929 I had to do some benchmarking, and I wanted to validate my findings against the ones that were done for 5.1.

The percentages don't seem to be correct - this PR updates them based on https://www.calculatorsoup.com/calculators/algebra/percent-change-calculator.php

Issues

Copy link
Member

@emteknetnz emteknetnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure this is incorrect

Putting in 0.1819 and 0.1453 into the linked calculator shows a 20.1209% decrease, so I see where you got the 20% from.

However the changelog says that it's performs 25% FASTER, not that it's resulted in a 20% decrease in time

e.g. You make a 500 km trip at 100kmh in 5 hours. If you make the same trip in 4 hours that's a 20% decrease in time. However you'd be going at 125kmh which is a 25% increase in speed, e.g. your vehicle is now 25% faster

We had some argument when the work was orginally done about which metric to use i.e. "time taken" or "faster". We ended up going with faster

I'll close the PR

@emteknetnz emteknetnz closed this Feb 19, 2024
@GuySartorelli GuySartorelli deleted the pulls/5.1/update-eagerloading-percentages branch February 19, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants