Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass document direction info to font shaper by default #1499

Merged
merged 2 commits into from
Aug 3, 2022

Conversation

alerque
Copy link
Member

@alerque alerque commented Jul 29, 2022

Fixes #1472

@alerque alerque requested a review from simoncozens as a code owner July 29, 2022 14:55
@alerque alerque added this to the v0.14.0 milestone Jul 29, 2022
@alerque alerque added the bug Software bug issue label Jul 29, 2022
@alerque
Copy link
Member Author

alerque commented Jul 29, 2022

These changes feel right to me, but an opinion from somebody that actually publishes stuff in directions other than TTB-LTR would be welcome. @ctrlcctrlv @khaledhosny @simoncozens ...

As of this PR:

  • When setting the direction option of a document class, the font.direction setting's default value is changed to match.
  • When setting the direction of the current frame, the font.direction settings current value is changed to match.

Does this feel right over the prior behavior of being expected to set this manually (via either \set[parameter=font.direction] or \font[direction=]) in addition to setting the class or frame properties so things other than shaped text advance correctly?

@alerque alerque requested a review from ctrlcctrlv July 29, 2022 17:02
@alerque
Copy link
Member Author

alerque commented Aug 3, 2022

Baring feedback I'm moving ahead with what makes sense to me here, but I'm happy to review again if this turns out to be unexpected behavior.

@alerque alerque merged commit f2412a1 into sile-typesetter:master Aug 3, 2022
@alerque alerque deleted the ttb-dir branch August 3, 2022 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Software bug issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mongolian shaping is foo-bared
1 participant