Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mongolian shaping is foo-bared #1472

Closed
alerque opened this issue Jul 7, 2022 · 2 comments · Fixed by #1499
Closed

Mongolian shaping is foo-bared #1472

alerque opened this issue Jul 7, 2022 · 2 comments · Fixed by #1499
Assignees
Labels
bug Software bug issue
Milestone

Comments

@alerque
Copy link
Member

alerque commented Jul 7, 2022

I noticed while reviewing the Jekyll→Zola transition on the website that our Mongolian example output has shaping that is is pretty much borked to pieces:

image

A couple quick tests with docker suggest it was last working properly in v0.11.1 and anything v0.12.0–HEAD turns up the same scrambled output. Not a proper bisect yet, but at least a range to look into.

The website file content/examples/mongolian.sil is suitable as a regression test, although it could probably use cleanup.

@alerque alerque added the bug Software bug issue label Jul 7, 2022
@ctrlcctrlv
Copy link
Member

Likely related to my CJK tate thoughts.

@alerque
Copy link
Member Author

alerque commented Jul 29, 2022

c.f. #501 and #1245.

Yes the CJK / tate / everything related is a mess, but this particular issue may actually be a bogus example on our part. It works fine if I set the font direction correctly, the example here sets it to a bogus value missing the TTB bit (kind of important). The only other thing is I would have expected the frame direction to propagate to the font direction without having to set it manually, so I'll look into that briefly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Software bug issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants