Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add functionality to bump a version #417

Merged
merged 2 commits into from
Oct 3, 2022

Conversation

asraa
Copy link
Contributor

@asraa asraa commented Sep 28, 2022

Signed-off-by: Asra Ali asraa@google.com

This is to handle bumping a version of a delegation #410 (comment) after #327

Summary

Release Note

Documentation

Signed-off-by: Asra Ali <asraa@google.com>
joshuagl
joshuagl previously approved these changes Sep 29, 2022
Copy link
Member

@joshuagl joshuagl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, but looks fine to me.

pkg/repo/repo.go Outdated Show resolved Hide resolved
pkg/repo/repo.go Show resolved Hide resolved
@asraa
Copy link
Contributor Author

asraa commented Sep 30, 2022

TODO: I just realized this may not refresh the expiration. This isn't strictly needed right now (because the particular file I need to refresh expires in January), but I will add a comment mentioning that in the doc string so we don't forget later.

Signed-off-by: Asra Ali <asraa@google.com>
@joshuagl joshuagl merged commit f3227c7 into sigstore:main Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants