Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repo: update revocation delegation to use length for rust compatibility #327

Merged
merged 2 commits into from
Jul 18, 2022

Conversation

asraa
Copy link
Contributor

@asraa asraa commented Jul 18, 2022

Signed-off-by: Asra Ali asraa@google.com

Summary

go-tuf would omit on empty (0 value) length fields. the delegation revocation had a placeholder revocation file that had no content, and so omitted the required length field. This broke tuftool used by sigstore-rs.

This re-signs the revocation metadata file. Steps performed:

  • Patched in a local copy of go-tuf that included this change: fix: require length and hashes for target metadata theupdateframework/go-tuf#345
  • Added a "length": 0 to the revocation.list
  • ./tuf sign -repository $REPO -roles revocation -key ${REVOCATION_KEY}: to resign the revocation delegation with the online key
  • LOCAL=1 ./scripts/step-4.sh to snapshot and timestamp the update
  • LOCAL=1 ./scripts/step-5.sh to publish.

Release Note

Documentation

Signed-off-by: Asra Ali <asraa@google.com>
@asraa
Copy link
Contributor Author

asraa commented Jul 18, 2022

cc @raulcabello: this should fix the rust client, please check if you can locally (it is being checked in CI too)

side note: is there a faster way to cargo install on CI? it takes a long time

Signed-off-by: Asra Ali <asraa@google.com>
@haydentherapper
Copy link
Contributor

What's the long-term fix? Is this a client issue not following the spec?

@asraa
Copy link
Contributor Author

asraa commented Jul 18, 2022

What's the long-term fix? Is this a client issue not following the spec?

Yes, see the description for the fix in go-tuf.

@asraa asraa requested a review from dlorenc July 18, 2022 17:19
@asraa
Copy link
Contributor Author

asraa commented Jul 18, 2022

I think it seems like the rust TUF folks are offline, going to merge this to trigger it in pre-prod.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants