Add RootCert method to client + tests #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add tests for exercising STL * Fix sigstore#289 * Validates that the new STL tests failed unless backporting sigstore#288 Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
vaikas
commented
Dec 21, 2021
| @@ -112,6 +118,9 @@ func (c *client) SigningCert(cr CertificateRequest, token string) (*CertificateR | |||
|
|
|||
| // Split the cert and the chain | |||
| certBlock, chainPem := pem.Decode(body) | |||
| if certBlock == nil { | |||
There was a problem hiding this comment.
FYI, since Decode returns nil for certBlock if it can't find a PEM, I added this check since it certainly seemed like it must return a cert or it should be considered a failure?
vaikas
changed the title
This was referenced Dec 21, 2021
Closed
dlorenc
approved these changes
Dec 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clientandapi_test.goas well. #289Signed-off-by: Ville Aikas vaikas@chainguard.dev
Summary
Ticket Link
Fixes
Release Note