Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the new RootCert this to the client and api_test.go as well. #289

Closed
vaikas opened this issue Dec 21, 2021 · 1 comment · Fixed by #290
Closed

Add the new RootCert this to the client and api_test.go as well. #289

vaikas opened this issue Dec 21, 2021 · 1 comment · Fixed by #290

Comments

@vaikas
Copy link
Contributor

vaikas commented Dec 21, 2021

We should add this to the client and api_test.go as well.

Originally posted by @mattmoor in #287 (review)
@vaikas
Copy link
Contributor Author

vaikas commented Dec 21, 2021

I'll do this, I can't assign to myself, but I'll do it :)

@vaikas vaikas mentioned this issue Dec 21, 2021
Merged
vaikas added a commit to vaikas/fulcio that referenced this issue Dec 21, 2021
@vaikas
* Add RootCert method to client + tests
4baf9bf 
* Add tests for exercising STL
* Fix sigstore#289
* Validates that the new STL tests failed unless backporting sigstore#288

Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
@vaikas vaikas mentioned this issue Dec 21, 2021
Merged
dlorenc pushed a commit that referenced this issue Dec 21, 2021
@vaikas
* Add RootCert method to client + tests (#290)
cdbc88b 
* Add tests for exercising STL
* Fix #289
* Validates that the new STL tests failed unless backporting #288

Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add RootCert method to client + tests vaikas/fulcio
1 participant
@vaikas