Fix context manager for older node versions #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Async hooks context manager needs to be activated by calling `.enable()` before it can be used as a context manager. This is important for older versions of node that don't use support local storage context manager.
owais
force-pushed
the
fix-ctx-manager-for-node-14_7-and-older
branch
from
eab8604 to
ee9bb13
Compare
Codecov Report
@@ Coverage Diff @@
## main #53 +/- ##
==========================================
+ Coverage 85.62% 85.79% +0.17%
==========================================
Files 10 10
Lines 167 169 +2
Branches 29 29
==========================================
+ Hits 143 145 +2
Misses 24 24
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Async hooks context manager needs to be activated by calling
.enable()before it can be used as a context manager. This is important for older
versions of node that don't use support local storage context manager.
We need to release this as a hot fix. Will follow up with a test case to catch any regressions in future.
fixes #50