-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jaeger traces don't seem to be getting suppressed w/ v0.5.0 #50
Comments
Thanks. I'll look into this Tuesday (traveling tomorrow). |
Just ran a quick test but couldn't reproduce it. I see the log statement you mentioned above but I don't see any spans being generated for the Jaeger exporter. Neither do I see multiple, continuous log statements. When you run it, do you see "creating span for request /v1/trace" being printed infinitely after issuing a single request to http://localhost:7000/test ? Which node version are you using? |
I was using v10 earlier but tried w/ 12 and 14 as well. Able to reproduce in both versions 🤔 issue.mov |
Definitely looks like the exporter being traced but not sure how to repro yet. Will try again with same version of node. |
I can reproduce it with 14.7.0 but not with 15.x. This is a good. I'll dig deeper and let you know once I more info. |
@maxmil7 Thanks for the detailed example and screencast. Can you please try 0.6.0 and see if that fixes the issue? |
Yes, v0.6.0 seems to work well. Thanks for the quick fix! |
I upgraded to v0.5.0 and it seems that the Jaeger traces aren't getting suppressed anymore. As a result, application is continuously creating spans even if there are no incoming requests.
Added an example here (simple express app w/ out of box config) : https://github.com/maxmil7/async-demo/tree/sfx-distro (branch sfx-distro)
Upon hitting the index page we can see the following logs in console:
The text was updated successfully, but these errors were encountered: