Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.8.0 #726

Merged
merged 10 commits into from
Apr 5, 2022
Merged

Release v0.8.0 #726

merged 10 commits into from
Apr 5, 2022

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Apr 1, 2022

Added

Changed

Fixed

  • Consistently import github.com/jackc/pgx/v4, instead of github.com/jackc/pgx, in the github.com/signalfx/splunk-otel-go/instrumentation/github.com/jackc/pgx/splunkpgx instrumentation. (Use jackc/pgx/v4 consistently #478)

@MrAlias MrAlias requested review from a team as code owners April 1, 2022 17:19
@codecov-commenter
Copy link

codecov-commenter commented Apr 1, 2022

Codecov Report

Merging #726 (c9eab99) into main (ce2bf75) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #726   +/-   ##
=======================================
  Coverage   79.55%   79.55%           
=======================================
  Files          56       56           
  Lines        2798     2798           
=======================================
  Hits         2226     2226           
  Misses        525      525           
  Partials       47       47           
Flag Coverage Δ
Linux 79.19% <100.00%> (ø)
Windows 75.74% <100.00%> (ø)
macOS 75.48% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
version.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce2bf75...c9eab99. Read the comment docs.

CHANGELOG.md Outdated Show resolved Hide resolved
@pellared
Copy link
Contributor

pellared commented Apr 5, 2022

- Update `go.opentelemetry.io/otel*` dependencies from [`v1.3.0`][otel-v1.3.0]
  to [`v1.6.1`][otel-v1.6.1]. (#656, #720)
- Update `go.opentelemetry.io/contrib*` dependencies from
  [`v1.4.0`/`v0.30.0`][contrib-v1.4.0] to [`v1.6.0`/`v0.31.0`][contrib-v1.6.0].
  (#720)

this section in CHANGELOG.md needs little fixes

  1. I think that Bump go.opentelemetry.io/otel from 1.6.0 to 1.6.1 in /instrumentation/gopkg.in/olivere/elastic/splunkelastic/test #720 hyperlink is wrong. Personally, I would even omit the PRs hyperlinks for bumping dependencies (not worth the effort).
  2. go.opentelemetry.io/contrib* were bumped from v0.28.0 and v1.3.0

@pellared
Copy link
Contributor

pellared commented Apr 5, 2022

I think this #492 should be added to the Changed section
MAYBE this one #494 as well (I am not sure)

@MrAlias
Copy link
Contributor Author

MrAlias commented Apr 5, 2022

I think this #492 should be added to the Changed section MAYBE this one #494 as well (I am not sure)

Those are not user facing changes. I'm not sure they are relevant to the end user reading the changelog.

@pellared
Copy link
Contributor

pellared commented Apr 5, 2022

This one is user-facing: #492

Different package path (user would need to update the go.mod)

@MrAlias
Copy link
Contributor Author

MrAlias commented Apr 5, 2022

This one is user-facing: #492

Different package path (user would need to update the go.mod)

Gotcha 👍

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@pellared pellared changed the title Release V0.8.0 Release v0.8.0 Apr 5, 2022
Copy link
Contributor

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few suggestions. Everything else LGTM. I will let you know when I finish smoke testing.

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Robert Pająk <pellared@hotmail.com>
@MrAlias MrAlias merged commit 620cbe1 into signalfx:main Apr 5, 2022
@MrAlias MrAlias deleted the v0.8.0 branch April 5, 2022 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants