Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make distro its own module #492

Merged
merged 1 commit into from
Mar 15, 2022
Merged

Make distro its own module #492

merged 1 commit into from
Mar 15, 2022

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Mar 14, 2022

Isolate the dependencies of the distro package from all other packages that import splunk-otel-go (e.g. SDK, gRPC, protobuf)

@MrAlias MrAlias requested review from a team as code owners March 14, 2022 18:32
Isolate the dependencies of the distro package from all other packages
that import splunk-otel-go (e.g. SDK, gRPC, protobuf)
@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2022

Codecov Report

Merging #492 (0a03aed) into main (c2727f0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #492   +/-   ##
=======================================
  Coverage   79.34%   79.34%           
=======================================
  Files          55       55           
  Lines        2769     2769           
=======================================
  Hits         2197     2197           
  Misses        525      525           
  Partials       47       47           
Flag Coverage Δ
Linux 78.98% <ø> (ø)
Windows 75.45% <ø> (ø)
macOS 75.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2727f0...0a03aed. Read the comment docs.

go.mod Show resolved Hide resolved
@MrAlias MrAlias merged commit be65ae3 into signalfx:main Mar 15, 2022
@MrAlias MrAlias deleted the dist-mod branch March 15, 2022 15:29
@pellared pellared mentioned this pull request Apr 5, 2022
MrAlias added a commit that referenced this pull request Apr 5, 2022
* Release v0.8.0

* Release v0.8.0

* Fix internal import version

* Fix spelling error in changelog

* Fix changelog

* Add #492 to changelog

* Apply suggestions from code review

Co-authored-by: Robert Pająk <pellared@hotmail.com>

Co-authored-by: Robert Pająk <pellared@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants