splunkclient-go: Do not use incorrect build tags #2891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
srv-gh-o11y-gdi-cla
added a commit
to splunk/cla-agreement
that referenced
this pull request
Feb 16, 2024
|
recheck |
pellared
reviewed
Feb 19, 2024
instrumentation/k8s.io/client-go/splunkclient-go/option/option.go
Outdated
Show resolved
Hide resolved
pellared
reviewed
Feb 19, 2024
There was a problem hiding this comment.
@andrewwdye Thanks for the issue and PR 👍
Can you also try adding a changelog entry to make the PR more complete?
pellared
approved these changes
Feb 20, 2024
pellared
changed the title
pellared
changed the title
pellared
changed the title
pellared
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2891 +/- ##
==========================================
+ Coverage 78.34% 80.04% +1.70%
==========================================
Files 85 88 +3
Lines 3293 2897 -396
==========================================
- Hits 2580 2319 -261
+ Misses 639 502 -137
- Partials 74 76 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
MrAlias
approved these changes
Feb 20, 2024
|
@andrewwdye thank you for the contribution! Please sign your commits. We required signed commits for the project to ensure authenticity. |
andrewwdye
force-pushed
the
splunkclient-go-min-version
branch
from
d6de4fc to
edebcc2
Compare
Signed-off-by: Andrew Dye <andrewwdye@gmail.com>
Signed-off-by: Andrew Dye <andrewwdye@gmail.com>
Signed-off-by: Andrew Dye <andrewwdye@gmail.com>
signalfx#2892) Bumps [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint) from 1.56.1 to 1.56.2. - [Release notes](https://github.com/golangci/golangci-lint/releases) - [Changelog](https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md) - [Commits](golangci/golangci-lint@v1.56.1...v1.56.2) --- updated-dependencies: - dependency-name: github.com/golangci/golangci-lint dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
andrewwdye
force-pushed
the
splunkclient-go-min-version
branch
from
edebcc2 to
33d3b6a
Compare
|
I rebased with my commits signed (and @pellared 's commits signed as co-authored). I assume there is another step here to co-sign but was unsure |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
go build(and friends) include build tags for current and prior versions of go (i.e., go 1.21 has tags go1.21, go1.20, go1.19, ...). The existinggo:builddirective in splunkclient-go checks the for absence of tags go1.1 -> go1.16, which will always fail.This change modifies the directive to indicate go 1.17 as the min version.
Also fixed lint and test failures. For the latter, removed attributed that were tested for but not returned from
ClientRequestfor semconv 1.17.Testing
Before
After
fixes #2890