You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the issue
The go:build directives in splunkclient-go prevent building in recent versions of go. Attempts to import github.com/signalfx/splunk-otel-go/instrumentation/k8s.io/client-go/splunkclient-go/transport per the example fail with undefined errors.
Looks like this attempt to require >= go1.17 does not work as expected and should instead by a single directive like //go:build go1.17 to indicate min version.
Steps to reproduce the issue:
❯ git clone https://github.com/signalfx/splunk-otel-go.git
❯ cd splunk-otel-go/instrumentation/k8s.io/client-go/splunkclient-go
❯ go test ./... -v
? github.com/signalfx/splunk-otel-go/instrumentation/k8s.io/client-go/splunkclient-go [no test files]
? github.com/signalfx/splunk-otel-go/instrumentation/k8s.io/client-go/splunkclient-go/internal/config [no test files]
? github.com/signalfx/splunk-otel-go/instrumentation/k8s.io/client-go/splunkclient-go/option [no test files]
? github.com/signalfx/splunk-otel-go/instrumentation/k8s.io/client-go/splunkclient-go/transport [no test files]
❯ go version
go version go1.21.3 darwin/arm64
Attempted solutions and workarounds
Simply replacing
Describe the issue
The
go:build
directives insplunkclient-go
prevent building in recent versions of go. Attempts to importgithub.com/signalfx/splunk-otel-go/instrumentation/k8s.io/client-go/splunkclient-go/transport
per the example fail with undefined errors.Looks like this attempt to require >= go1.17 does not work as expected and should instead by a single directive like
//go:build go1.17
to indicate min version.Steps to reproduce the issue:
Attempted solutions and workarounds
Simply replacing
with
seems to address the problem
Expected behavior
Existing tests run
Environment
Complete the following information:
Additional context
N/A
The text was updated successfully, but these errors were encountered: