Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #82 crash on startup when no project is previously selected. #93

Merged
merged 1 commit into from
Apr 6, 2024
Merged

Fixes #82 crash on startup when no project is previously selected. #93

merged 1 commit into from
Apr 6, 2024
+12 −4

Commits on Apr 5, 2024

  1. Fix crash on startup (issue shpaass#82) when no project is previously… 

    … selected.

This bug was introduced in shpaass@8f1e04e by changing `struct RecentProject` to `class ProjectDefinition`. By making this type a reference, the default value is now null, instead of an object with all fields set to default, which leads to crashes when it is dereferenced.

This fix makes the SetProject() function accept null as an arugment and then configures all variables as they would have been before. This continues to run the intialization code. Alternatively, we could skip the call to SetProject() entirely -- with my limited understanding of the code base, I don't know if that's safe or not.
    @jeady
    jeady committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    2961fe8 View commit details
    Browse the repository at this point in the history