-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crash off of first install on 0.6.2 #82
Comments
I also get the crash from a fresh install with no symlink involved |
Removing the tag |
failed to start on both windows and mac(apple silicon) |
How does this fail? Can you describe what happens? And @nnguyen259: Which OS? Are Factorio and YAFC also on different drives? The more information we have, the easier a fix would be. |
On a side note, I suggest to try the recent pre-release to see if anything changes. |
… selected. This bug was introduced in shpaass@8f1e04e by changing `struct RecentProject` to `class ProjectDefinition`. By making this type a reference, the default value is now null, instead of an object with all fields set to default, which leads to crashes when it is dereferenced. This fix makes the SetProject() function accept null as an arugment and then configures all variables as they would have been before. This continues to run the intialization code. Alternatively, we could skip the call to SetProject() entirely -- with my limited understanding of the code base, I don't know if that's safe or not.
Fixes #82 This bug was introduced in 8f1e04e by changing `struct RecentProject` to `class ProjectDefinition`. By making this type a reference, the default value is now null, instead of an object with all fields set to default, which leads to crashes when it is dereferenced. This fix makes the SetProject() function accept null as an arugment and then configures all variables as they would have been before. This continues to run the intialization code. Alternatively, we could skip the call to SetProject() entirely -- with my limited understanding of the code base, I don't know if that's safe or not. I don't feel strongly about the approach, happy to do either. #89 also fixes this by skipping the call to SetProject() if project is null, but I think it makes sense to decouple this quick bug fix from the rest of the feature work there.
I'm reopening this since I'd like to have some validation if it really fixed the crash. |
I tried both the RC and the 0.6.2 and it just starts a white window and then crashes in Windows. Are there logs anywhere that I can post here? |
@shadghost please try versions prevoius to 0.6.2 and let us know the results. That will help to understand the issue better. |
Workaround: Download / start 0.6.1, it will error out on flib, after you get to the flib error download and start 0.6.3-RC1 and it will start and everything works. |
Any news on this? |
I think we close this one and make a new issue if more crashes get reported. |
When installing YAFC-CE from scratch (ver. 0.6.2) on a separate disk from my Factorio install (same PC) YAFC launches to a blank white screen then closes immediately.
I'm running on Windows 10 Pro.
Steps to reproduce:
The text was updated successfully, but these errors were encountered: