Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add meta example for Sparse Euclidian Distance #3000 #4942

Closed
wants to merge 1 commit into from
Closed

Add meta example for Sparse Euclidian Distance #3000 #4942

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions examples/meta/src/distance/sparseeuclidean.sg
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
CSVFile f_feats_a("../../data/fm_train_sparsereal.dat")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong file name.... should be sg.in

Copy link
Member

@gf712 gf712 Mar 18, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also use SHOGUN_DATA instead of relative path

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand.
This was the filename in the existing python example as well.
Also, I don't see any sg.in file in the data directory.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be examples/meta/src/distance/sparseeuclidean.sg.in you'll see that all other examples have that extension....

and plz check the other examples for how the data file path is being defined.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and as a general rule it'd be great if you could test (compile and run) any patch before you create a pull request

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hephaestus12 just add make it more clear, @vigsterkr was not talking about the filename in the csv file, but about the filename of the meta example listing itself

CSVFile f_feats_b("../../data/fm_test_sparsereal.dat")

#![create_features]
Features features_a = features(f_feats_a)
Features features_b = features(f_feats_b)
#![create_features]

#![create_instance]
Distance d = distance("SparseEuclideanDistance", lhs=features_a, rhs=features_a)
#![create_instance]

#![extract_distance]
RealMatrix distance_matrix_aa = d.get_distance_matrix()
#![extract_distance]

#![refresh_distance]
d.init(features_a, features_b)
RealMatrix distance_matrix_ab = d.get_distance_matrix()
#![refresh_distance]
26 changes: 0 additions & 26 deletions examples/undocumented/python/distance_sparseeuclidean.py
View file
Open in desktop

This file was deleted.