Add meta example for Sparse Euclidian Distance #3000 #4942
Conversation
Changes to be committed: new file: examples/meta/src/distance/sparseeuclidean.sg deleted: examples/undocumented/python/distance_sparseeuclidean.py
Hephaestus12
changed the title
| @@ -0,0 +1,20 @@ | |||
| CSVFile f_feats_a("../../data/fm_train_sparsereal.dat") | |||
There was a problem hiding this comment.
wrong file name.... should be sg.in
There was a problem hiding this comment.
also use SHOGUN_DATA instead of relative path
There was a problem hiding this comment.
I don't understand.
This was the filename in the existing python example as well.
Also, I don't see any sg.in file in the data directory.
There was a problem hiding this comment.
it should be examples/meta/src/distance/sparseeuclidean.sg.in you'll see that all other examples have that extension....
and plz check the other examples for how the data file path is being defined.
There was a problem hiding this comment.
and as a general rule it'd be great if you could test (compile and run) any patch before you create a pull request
There was a problem hiding this comment.
@Hephaestus12 just add make it more clear, @vigsterkr was not talking about the filename in the csv file, but about the filename of the meta example listing itself
Changes to be committed:
new file: examples/meta/src/distance/sparseeuclidean.sg
deleted: examples/undocumented/python/distance_sparseeuclidean.py