Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement decorator-based event handler registration #165

Merged
merged 1 commit into from
Jun 19, 2022
Merged

Implement decorator-based event handler registration #165

merged 1 commit into from
Jun 19, 2022

Conversation

theunkn0wn1
Copy link
Collaborator

Closes #145

  • drops support for python<3.5 if we haven't done that already.

@theunkn0wn1
Implement decorator-based event handler registration
0166bef 
 - for those who prefer not subclassing.
@theunkn0wn1 theunkn0wn1 mentioned this pull request Mar 26, 2022
Closed
Rixxan
Rixxan approved these changes Mar 26, 2022
View reviewed changes
Copy link
Contributor

@Rixxan Rixxan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Recommend updating README as well to update minimum Python version.

@theunkn0wn1 theunkn0wn1 mentioned this pull request Mar 26, 2022
Open
@theunkn0wn1 theunkn0wn1 merged commit 575bd93 into shizmob:develop Jun 19, 2022
@theunkn0wn1 theunkn0wn1 deleted the user/theunkn0wn1/feature/discord_like_event_registration branch June 19, 2022 19:42
@theunkn0wn1 theunkn0wn1 mentioned this pull request Jun 19, 2022
Merged
bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request Sep 30, 2022
@bmwiedemann
Update python-pydle to version 1.0.0 / rev 10 via SR 1007087
d3ad1c9 
https://build.opensuse.org/request/show/1007087
by user mia + RBrownFactory
- Update to version 1.0.0
  Major changes:
  * API change, monitor and unmonitor are now async def functions
    gh#shizmob/pydle#144
  * Drop support for Python < 3.5
    gh#shizmob/pydle#165
  Bug fixes:
  * Fix parsing IRCv3 tags with missing/empty values
    gh#shizmob/pydle#149
  * Fixup irccat.py example
    gh#shizmob/pydle#152
  * WHOIS uses deprecated @asyncio.coroutine
    Backward compatable as the interface did not effectively change
    gh#shizmob/pydle#161
  * Fix Missing Awaits in various files
    Some internal methods were made async. As these methods are
    internal, they are not covered by SEMVER.
    gh#shizmob/pydle#164
  * Add Missing awaits in coroutine calls
    gh#shizmob/pydle#170
  Features:
  * Enable RplWhoisHostSupport implementation
    gh#shizmob/pydle#156
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rixxan Rixxan Rixxan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Decorator-based callback registration
2 participants
@theunkn0wn1 @Rixxan