monitor support fixes
#144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to current IRCv3 documentation, server support for `monitor` is indicated in `RPL_ISUPPORT`, and not in capability negotiation.
Per spec, servers are allowed to send a full `nick!user@host` mask instead of just a nickname in `RPL_MON*` replies.
theunkn0wn1
approved these changes
Jun 21, 2020
Co-authored-by: Joshua Salzedo <thHunkn0WNd@gmail.com>
Merged
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Sep 30, 2022
https://build.opensuse.org/request/show/1007087 by user mia + RBrownFactory - Update to version 1.0.0 Major changes: * API change, monitor and unmonitor are now async def functions gh#shizmob/pydle#144 * Drop support for Python < 3.5 gh#shizmob/pydle#165 Bug fixes: * Fix parsing IRCv3 tags with missing/empty values gh#shizmob/pydle#149 * Fixup irccat.py example gh#shizmob/pydle#152 * WHOIS uses deprecated @asyncio.coroutine Backward compatable as the interface did not effectively change gh#shizmob/pydle#161 * Fix Missing Awaits in various files Some internal methods were made async. As these methods are internal, they are not covered by SEMVER. gh#shizmob/pydle#164 * Add Missing awaits in coroutine calls gh#shizmob/pydle#170 Features: * Enable RplWhoisHostSupport implementation gh#shizmob/pydle#156
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes many issues with Pydle's support for the
monitorextension, as detailed in #143.Summary
RPL_ISUPPORT, not capabilities.monitorandunmonitormethods were made to be coroutines, as they were not beforeRPL_MON*replies would always return bare nicknames, when in fact the server may return fullnick!user@hostmasks.Feel free to let me know of anything else you found, or go ahead and push to this branch.