Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump tekton-pipeline to v0.17.1 #447

Merged
merged 3 commits into from
Oct 28, 2020
Merged

Bump tekton-pipeline to v0.17.1 #447

merged 3 commits into from
Oct 28, 2020

Conversation

xiujuan95
Copy link
Contributor

@xiujuan95 xiujuan95 commented Oct 21, 2020

Fix issue: #429

Bump go modules to point to v0.17.1 tekton-pipeline version;

Modify vendor directory and make it have all new dependencies;

Add some dependent packages to fix some Incompatible issues:

  • k8s.io/apimachinery => k8s.io/apimachinery v0.17.6
k8s.io/klog/v2
# k8s.io/klog/v2
vendor/k8s.io/klog/v2/klog.go:1241:34: cannot use logging.logr.V(int(level)) (type logr.InfoLogger) as type logr.Logger in field value:
        logr.InfoLogger does not implement logr.Logger (missing Error method)

v0.17.6 can solve above issue.

  • sigs.k8s.io/controller-runtime => sigs.k8s.io/controller-runtime v0.5.2
k8s.io/klog/v2
# k8s.io/klog/v2
vendor/k8s.io/klog/v2/klog.go:1241:34: cannot use logging.logr.V(int(level)) (type logr.InfoLogger) as type logr.Logger in field value:
        logr.InfoLogger does not implement logr.Logger (missing Error method)
sigs.k8s.io/controller-runtime/pkg/webhook/internal/certwatcher

v0.5.2 can get rid of this issue.

  • k8s.io/kube-openapi => k8s.io/kube-openapi v0.0.0-20200410145947-bcb3869e6f29
vendor/k8s.io/kube-openapi/pkg/util/proto/document.go:24:2: case-insensitive import collision: "github.com/googleapis/gnostic/openapiv2" and "github.com/googleapis/gnostic/OpenAPIv2"
make: *** [build/_output/bin/build-operator] Error 1

v0.0.0-20200410145947-bcb3869e6f29 can solve this issue.

  • github.com/go-logr/logr => github.com/go-logr/logr v0.1.0
github.com/go-logr/zapr
# github.com/go-logr/zapr
vendor/github.com/go-logr/zapr/zapr.go:133:34: undefined: logr.InfoLogger

v0.2.0 release doesn't have logr.InfoLogger

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 21, 2020
@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 21, 2020
@openshift-ci-robot
Copy link

Hi @xiujuan95. Thanks for your PR.

I'm waiting for a shipwright-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xiujuan95 xiujuan95 changed the title [WIP] Bump tekton-pipeline to v0.17.1 Bump tekton-pipeline to v0.17.1 Oct 21, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 21, 2020
@xiujuan95 xiujuan95 mentioned this pull request Oct 21, 2020
@qu1queee
Copy link
Contributor

I will take a look today, I want this to get in asap.

@SaschaSchwarze0
Copy link
Member

/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 21, 2020
Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the README.md. The Tekton version is mentioned twice.

Copy link
Member

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

There are multiple changes to k8s deps that impact operator-sdk. I am working on a separate PR to bump operator-sdk and k8s - it seems that Tekton needs to be bumped in that PR as well. See #443

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 21, 2020
@qu1queee
Copy link
Contributor

@adambkaplan I took a look on this, Im not sure if this PR should be blocked. Please refer to this branch where I pinned the missing dependencies that this PR didnt.

Also, it seems Tekton is doing the same, look at their go modules in v0.17.1 vs master . Is there any specific reason on why this one should be blocked? if not I suggest that @xiujuan95 fixes the PR and then we put on top your upcoming #443

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 22, 2020
@zhangtbj
Copy link
Contributor

Hi @adambkaplan ,

Any update in your PR?

Will you bump the Tekton in your PR or can we continue this PR?

@zhangtbj
Copy link
Contributor

Hi @adambkaplan ,

This PR blocks our work recently. If your PR cannot finish soon.

I suggest we go ahead and accept this PR first. Please let us know if you have any comment or suggestion.

I plan to unblock this issue tomorrow if no other objection.

Thanks!

@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 27, 2020
@zhangtbj
Copy link
Contributor

/ok-to-test

@zhangtbj
Copy link
Contributor

/ok-to-test

@zhangtbj zhangtbj removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 28, 2020
@zhangtbj
Copy link
Contributor

/unhold

@zhangtbj
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 28, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zhangtbj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 28, 2020
@openshift-merge-robot openshift-merge-robot merged commit 5c1ee56 into shipwright-io:master Oct 28, 2020
@qu1queee qu1queee mentioned this pull request Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants