Get rid of InfoLogger, make V() additive #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per go-logr#6, simplify. InfoLogger is no more. There is only Logger. This is a breaking change. Document V() as additive: `l.V(1).V(2) is the same as `l.V(3)`
DirectXMan12
approved these changes
Jun 11, 2020
|
should we bump the module version too? This is a breaking change |
|
"bump version" means tag 0.2.0 ?
…On Wed, Jun 10, 2020 at 5:35 PM Solly Ross ***@***.***> wrote:
should we bump the module version too? This is a breaking change
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #6, simplify.
InfoLogger is no more. There is only Logger. This is a breaking
change.
Document V() as additive:
l.V(1).V(2) is the same asl.V(3)`Fixes #6