Enhance docs by adding contributing and code-of-conduct files #372
Conversation
|
thanks folks, reviewing the feedback tomorrow |
We reference to the Kubernetes community one, in the same way as most of the Kubernetes existing projects
qu1queee
force-pushed
the
qu1queee/359
branch
from
03ac61b
to
194d8f1
Compare
Trying to add some initial words on future contributions. I think we still need to generate more docs for this, but so far is good to have this as an initial step.
qu1queee
force-pushed
the
qu1queee/359
branch
from
194d8f1
to
2d1b8d0
Compare
|
@adambkaplan @SaschaSchwarze0 @HeavyWombat I added the requested changes, please re-review. I think I got them all in, in case there is something missing please request changes again. Thanks for taking the time reviewing the new docs. |
There was a problem hiding this comment.
I can live with Build for now.
@qu1queee please squash your commits and we can merge.
|
|
||
| ## Contact Information | ||
|
|
||
| - [Slack channel](https://kubernetes.slack.com/archives/C019ZRGUEJC) |
There was a problem hiding this comment.
The slack channel is introduced in three places in this doc, I think we can reduce to 1 or 2 places
|
@adambkaplan when the bot merge, it will automatically squash, thats not a problem. Wondering if this is desired, I actually dont like this, will take a look on the settings |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zhangtbj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@qu1queee interesting...I can check into our configurations in openshift/release (which is how we set up the CI and merge bots). |
Add code of conduct doc
as most of the Kubernetes existing project
Add contributing doc
still need to generate more docs for this, but so far is good to have
this as an initial step.