Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♿ Remove tabindex to reduce tabs for modal trap #3083

Merged
merged 1 commit into from
Jan 2, 2025
Merged

♿ Remove tabindex to reduce tabs for modal trap #3083

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion shepherd.js/src/components/shepherd-content.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
export let descriptionId, labelId, step;
</script>

<div class="shepherd-content" tabindex="0">
<div class="shepherd-content">
{#if !isUndefined(step.options.title) || (step.options.cancelIcon && step.options.cancelIcon.enabled)}
<ShepherdHeader {labelId} {step} />
{/if}
Expand Down
3 changes: 2 additions & 1 deletion test/cypress/integration/a11y.cy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,8 @@ describe('a11y', () => {

cy.document().then(() => {
cy.wait(1000);
cy.get('.shepherd-content').tab().tab().tab().tab().tab().tab().tab();
// Tabbing out of the modal should not be possible and we test this by tabbing from the body
cy.get('body').tab().tab().tab().tab().tab().tab();
cy.get('[data-test-popper-link]').should('have.focus');
});
});
Expand Down
Loading