Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♿ Remove tabindex to reduce tabs for modal trap #3083

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

chuckcarpenter
Copy link
Member

closes #3071

This removes the tabindex added by the content div that's not needed for tab trapping in the dialog.

Copy link

vercel bot commented Dec 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
shepherd-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 31, 2024 8:01pm
shepherd-landing ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 31, 2024 8:01pm

Copy link
Member

@RobbieTheWagner RobbieTheWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, good find!

@RobbieTheWagner RobbieTheWagner merged commit 142caf5 into main Jan 2, 2025
9 checks passed
@RobbieTheWagner RobbieTheWagner deleted the chore/improve-tab-focus branch January 2, 2025 16:00
@github-actions github-actions bot mentioned this pull request Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accessibility issue: unnecessary tabstop
2 participants