Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

development OAuth app details set #72

Open
iamthadiyan opened this issue Oct 15, 2018 · 13 comments
Open

development OAuth app details set #72

iamthadiyan opened this issue Oct 15, 2018 · 13 comments

Comments

@iamthadiyan
Copy link

Description

Installed 1.4.2 Linux RC1 in Ubuntu 16.04.5 LTS. Doing Enterprise login, OAuth fails with 404 error. The same procedure fine when tried with latest Windows client

Version

  • GitHub Desktop: 1.4.2 Linux RC1
  • Operating system:Ubuntu 16.04.5 LTS

Steps to Reproduce

  1. Launch desktop in Ubuntu 16.04.5 LTS
  2. Click File->Options->Accounts->Enterprise Signin
  3. Enter Enterprise URL
  4. Click on 'Sign In'
  5. Enterprise URL

Expected Behavior

OAuth to succeed and Desktop able to list repositories.

Actual Behavior

404 Page when redirected for OAuth. The same steps works correctly from windows version.

Additional Information

Logs

I do not know where to look for linux logs.

@shiftkey
Copy link
Owner

Yep, I know what this is - I'd change the deployment processes around in #63 and I neglected to add the production OAuth Client ID and Client Secret to the build process.

@shiftkey shiftkey self-assigned this Oct 15, 2018
@shiftkey shiftkey removed the needs-fix label Nov 2, 2018
@shiftkey shiftkey removed their assignment Nov 2, 2018
@shiftkey
Copy link
Owner

shiftkey commented Nov 2, 2018

For the moment I'm going to leave the OAuth Client ID and Secret as-is for these installers, because the other OAuth details are associated with the official apps and I shouldn't be using them to make installers generated from this fork.

While it's great to hear that you're trying to use this with GitHub Enterprise, the current priority for Linux support is to test the installers and app across a range of distros, so I'm going to leave this with the developer OAuth details set the moment (that will continue to work fine with GitHub.com).

@shiftkey shiftkey changed the title 404 Error using Enterprise login in Github Desktop Ubuntu version but same works in Windows client unable to login into Enterprise (wrong OAuth details set) Nov 2, 2018
@mryan43
Copy link

mryan43 commented Jan 4, 2019

here's my not-so-useful +1, our org also needs a fix for this !

@anish-joy
Copy link

When will this issue be fixed? Is there any alternate way to fix this issue, locally or organizational level until the alpha version releases!

@smcfizz
Copy link

smcfizz commented Jan 30, 2019

I have a very similar issue as well. When I enter my credentials for my organization in the GitHub Desktop app I receive

"The server responded with an error while attempting to authenticate (422)\n Unprocessable Entity"

and if I choose to "sign in using your browser" I am redirected to a 404, as described above.

@shiftkey shiftkey changed the title unable to login into Enterprise (wrong OAuth details set) development OAuth app details set May 12, 2019
@davidmcl
Copy link

Unfortunately, this bug makes your tool useless for me...my clients are not going to remove the 3rd party app restrictions. My scenario isn't on Enterprise, just Organizations.

@shiftkey
Copy link
Owner

Just to bump this with a comment from #229 (comment)

What you suggest to do then? On windows and Mac is working properly.

This is because I maintain the unofficial releases for Linux, and it doesn't contain the OAuth details required to behave the same. This is being discussed in desktop#1525 (please upvote if you care) but #72 is tracking this known limitation.

As I want to keep this separate until the team is interested in official support, the only other option here would be for me to embed a new set of OAuth details that would belong to a distinct entity to avoid confusion with the main "GitHub Desktop" product. That's branding work I'm not able to take on currently, and I want to focus currently on ensuring the app installs and works on various distros.

Introducing a new brand also won't address the solution completely because organization administrators need to approve access to this new application.

The command line works here because you're creating a token directly associated with your account, rather than delegating to an OAuth application.

@sc-sycer
Copy link

sc-sycer commented Jan 6, 2021

https://github.com/settings/applications

Click on "The GitHub Desktop Development App"

Scroll down to "Organization access"

You can grant or revoke access to organizations individually.

This! Please, put this into a FAQ or something! When I granted the access to organizations into github.com to the desktop application, my private repos began to work!

This was referenced Feb 20, 2023
@remenkemi
Copy link

remenkemi commented Sep 12, 2023

https://github.com/settings/applications

Click on "The GitHub Desktop Development App"

Scroll down to "Organization access"

You can grant or revoke access to organizations individually.

I don't seem to have any organization access settings. I saw the options on other OAuth apps but not this one.
Screenshot 2023-09-11 23 34 02

@o-hnne
Copy link

o-hnne commented Mar 26, 2024

So is it normal that View on Github, Create issue on Github and Preview Pull Request/Create Pull Request so basically stuff tied directly to Github.com is not working on an organisation repo compared to the Windows application even though Github Desktop and The Github Desktop Development App are OAuth authorized by the organisation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

12 participants