Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Links #39

Closed
Helladen opened this issue Apr 19, 2018 · 17 comments
Closed

GitHub Links #39

Helladen opened this issue Apr 19, 2018 · 17 comments
Labels
retest-requested Issue needs to be verified against latest version of app unclear

Comments

@Helladen
Copy link

The Github.com links don't show. I am using Fedora 27.

screenshot from 2018-04-18 20-13-18

@shiftkey
Copy link
Owner

@Aeirex thanks for the report!

Could you attach the full log files? The Help | Show Logs in your File Manager menu items should open the logs folder, and inside those are the log files generated by day. This will provide some more information to help troubleshoot.

@Helladen
Copy link
Author

I had this happen on Arch Linux as well.

I can't find any logs.

@Helladen Helladen mentioned this issue Apr 20, 2018
@shiftkey
Copy link
Owner

shiftkey commented May 7, 2018

install.ts:23 `git -c credential.helper= fetch --progress --prune origin` exited with an unexpected code: 128.
/opt/GitHubDesktop/resources/app/git/libexec/git-core/git-remote-https: /lib64/libcurl-gnutls.so.4: no version information available (required by /opt/GitHubDesktop/resources/app/git/libexec/git-core/git-remote-https)

This is likely why Git operations against your private repository are not working. I've found a workaround here for Fedora that might work for you: #21 (comment)

There also appear to be some networking errors when interacting with the GitHub API - Desktop needs libsecret on Linux to manage credentials, and it's not clear to me whether you have gnome-keyring or kwallet or neither installed - there's more details over in #7 about this.

@Helladen
Copy link
Author

Helladen commented May 8, 2018

@shiftkey I looked through my logs and see nothing useful. I also have already done this, it is already symbolic linked.

Here's all my logs.
2018-0.zip

@Helladen Helladen closed this as completed May 8, 2018
@shiftkey
Copy link
Owner

shiftkey commented May 8, 2018

@Helladen thanks for the log - looking at the most recent entry I see you've now got a valid token and can clone things down:

2018-05-03T12:28:11.272Z - info: [ui] [AppStore.getAccountForRemoteURL] account found for remote: https://github.com/KDE/kdeconnect-android.git - Aeirex (has token)

However I'm still puzzled why private repositories are returning a 404 for you - we should be using that same token here:

2018-05-03T12:28:13.737Z - warn: [ui] fetchRepository: 'HitsparkInteractive/Nin-Online-2.0' returned a 404

@Helladen
Copy link
Author

Helladen commented Jun 2, 2018

I got it working after signing out and back in.

@Helladen
Copy link
Author

Helladen commented Jun 9, 2019

Update. This bug still happens. I noticed that I can login to my GitHub account, but it only displays website. It doesn't show my private repositories. I also can't pull a repository like I can using bash. It will say I am not authenticated. I even logged out and back in fine. So the problem lies with the authentication system working with the login part.

@Helladen Helladen reopened this Jun 9, 2019
@immackay
Copy link

@Aeirex, the AUR package was not updated until today as I've been on vacation. Can you try now and report whether the problem still exists?

@Helladen
Copy link
Author

Helladen commented Jun 10, 2019

@immackay I'm using Fedora now. I use Git in terminal to clone and then add it to GitHub Desktop. It doesn't allow me to commit or fetch. I've logged in and out of the client using my GitHub account. It just lacks permissions to do anything.

@Helladen
Copy link
Author

I have private repositories that do not show also.

@shiftkey
Copy link
Owner

@Aeirex are they private GitHub or GitHub Enterprise repositories?

@Helladen
Copy link
Author

Helladen commented Jun 19, 2019

https://github.com/HitsparkInteractive

It's not Enterprise, we just pay $25/m for private repositories. This happens on Ubuntu 19.04, too. It seems to be a Linux problem.

@Helladen
Copy link
Author

Helladen commented Jun 23, 2019

@shiftkey when I add the Repository it won't let me push it either. It says the repository doesn't exist. Although using Git in the terminal I can pull and push them fine.

@Helladen
Copy link
Author

Helladen commented Jul 10, 2019

Still a problem. I am using Ubuntu 18.04.2 and this happens on multiple distros. I have been using SmartGit to pull repos as well as git in the terminal. It does not correctly load the repository though.

image

@shiftkey
Copy link
Owner

@Aeirex apologies for the delay in replying.

I believe this is related to organizations restricting access to third party applications, which would block Desktop from being able to push/pull to the repositories belonging to an organization.

This build of the app does not behave the same as the macOS and Windows versions because of #72, and I don't have a timeline on when this will be resolved as it's something that would be part of "official support" by GitHub.

The likely reason this works fine from the command line is because that results in a different way of authentication (i.e. personal access token or basic credentials) that are not tied to an OAuth application.

I know it's been a while, but would you be able to re-test with 2.4.0 and confirm this is the behaviour:

  • able to fetch repositories owned by the user after signing in
  • unable to fetch repositories owned by an organization after signing in

@shiftkey shiftkey added the retest-requested Issue needs to be verified against latest version of app label Mar 29, 2020
@Helladen
Copy link
Author

Helladen commented Apr 7, 2020

It still happens @shiftkey

@shiftkey
Copy link
Owner

shiftkey commented Apr 7, 2020

@Aeirex thanks for following up.

I'm going to close this out because #72 is the root cause of this behaviour. Please follow along with that issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
retest-requested Issue needs to be verified against latest version of app unclear
Projects
None yet
Development

No branches or pull requests

3 participants