Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create new web scraping section with readme overview and basic web scraping example #722

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

jakenybo
Copy link
Contributor

@jakenybo jakenybo commented Nov 6, 2023

create new web scraping section with readme overview and basic web scraping example

Proposed changes

Add new Web Scraping section. Create a readme overview of Web Scraping as well as a basic Web Scraping example.

Types of changes

What types of changes does your content introduce to this project?
Put an x in the boxes that apply (without "`")

  • Proofreading (fix spelling, grammar, punctuation, accuracy) Proofreading
  • New content (new section, new readme, etc.)
  • Modifications (modifying existing content)
  • Other (please describe)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. Don't hesitate to ask if you're unsure about any of them. We're here to help! This simply reminds us of what we will look for before merging your code.
Note: If you submit code make sure to test it

  • Tested any code that was added/modified in this PR
  • Added external links
  • Added internal links
  • Added images
  • Added videos
  • Added code snippets

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Adding your name to the contributor's list

Comment "@all-contributors please add @your_username for content" to add your name to the contributor's list.
You can change the "content" with any of this

Reviewers:

  • @username

Please ensure that you are not adding any sensitive information like API keys, secrets, passwords, tokens, usernames, or other credentials. Refrain from adding your name, email, or other personal information.

@the-label-bot the-label-bot bot added kind/documentation kind/documentation size/XL size/XL labels Nov 6, 2023
Copy link

the-label-bot bot commented Nov 6, 2023

The Label Bot has predicted the following:

Category Value Confidence Applied Label
Kind documentation 0.998 ✔️
Size XL 0.748 ✔️

@jakenybo
Copy link
Contributor Author

jakenybo commented Nov 6, 2023

https://github.com/all-contributors please add @jakenybo for content

Copy link
Owner

@shhossain shhossain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you change Web Technology/Web Scraping/Examples/0_Basic_Web_Scraping_Example.ipynb to a markdown file?

@jakenybo
Copy link
Contributor Author

jakenybo commented Nov 11, 2023

yes, i could, but then we would lose the functionality of being able to run snippets of Python code within the jupyter notebook. this is a very powerful way to understand the code. jupyter notebooks are becoming very popular in educational mediums. i'm currently taking master's courses that use jupyter notebooks like this for education.

i would strongly recommend that we make a change to allow jupyter notebooks to be used for teaching in this project. i feel that they would greatly add to the educational interactivity of this project. but, you are the project owner and i respect your vision for the project. do you want me to change my learning material for this new web scraping section to markdown .md files or will you allow us to implement jupyter notebooks for teaching?

i'll follow whatever you decide, thanks

@shhossain
Copy link
Owner

@jakenybo okay. let it stay.

@shhossain shhossain merged commit 9ebb0fe into shhossain:main Nov 16, 2023
1 check failed
@shhossain
Copy link
Owner

@all-contributors please add @jakenybo for content and code

Copy link
Contributor

@shhossain

I've put up a pull request to add @jakenybo! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation kind/documentation size/XL size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants