Invalid index error fix when reading variables from certain classes #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lasses, which prevented the completion menu from showing.
kana
added a commit
to kana/vim-phpcomplete
that referenced
this pull request
Oct 12, 2021
* 'master' of https://github.com/shawncplus/phpcomplete.vim: chore: fix typos with codespell (shawncplus#127) Apply popup-content manipulation patch from @lacygoill Cleanups and an another "Can't change text here" bugfix Fix plugin for vim 8.2.2426 and 8.2.2427 Add shortcut mapping to work in visual mode. (shawncplus#123) Fix for invalid index error when reading the variables from certain classes. (shawncplus#121) Fixed error messages displayed when extensions are missing. (shawncplus#120) Add filtering against functions removed since PHP 7.0.0 (shawncplus#119) Fix shawncplus#116 - jump to definition by tag line is not working Typofixes curtesy of Christ van Willegen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This error prevented the omnicomplete popup to showup when hitting an out of index error while reading a class variables list. Solution was to add a default empty string '' to the get call since get returns zero (0) by default which len is 1, another option would be get(variables, var_index) != 0 but I just thought about that :)