Skip to content

Conversation

jgmdev
Copy link
Contributor

@jgmdev jgmdev commented Sep 26, 2019

Lot of error messages where generated when completing for the first time due to main default extensions not loaded in PHP, this changes fix it.

@complex857
Copy link
Collaborator

Thank you for the pull request!
I've to admit, i'm a bit confused on what scenario these errors are appearing, I don't remember seeing them myself, but the changes look safe / sane, so I'll include them.

Cheers

@complex857 complex857 merged commit 16104ba into shawncplus:master Sep 28, 2019
@jgmdev
Copy link
Contributor Author

jgmdev commented Sep 29, 2019

Sorry that I didn't get into more detail, I'm running vim on Android using the Termux app, specifically I'm using a Samsung Galaxy 9+ in Dex mode which generates a Desktop like experience when is conntected to an external display that is friendly to keyboard and mouse. The Termux app ships some kind of distro linux distro in chroot that uses the pkg command to install software similar to AlpineLinux, and its repository PHP version has all extensions build statically except for opcache.

So when I ran the this repo plugin omni completion for the first time after launching vim it was complaning about non existent key for every of the extensions not shipped with the PHP binary shipped on the Termux app linux distro like mssql, etc... (I guess this plugin is using reflection to generate completion for php standard/included libraries). The older version shipped with vim doesn't has the same issue but it doesn't autocompletes correctly with namespaces.

This extension is also giving me errors when trying to autocomplete a specific class in a namespace like MyNS\Myclass:: but I haven't debug yet what is causing the issue, the error message is also related to an undefined key on a list. If I find what is the issue will open a issue here on Github or another Pull Request if I'm able to fix it. Thanks for the merge!

kana added a commit to kana/vim-phpcomplete that referenced this pull request Oct 12, 2021
* 'master' of https://github.com/shawncplus/phpcomplete.vim:
  chore: fix typos with codespell (shawncplus#127)
  Apply popup-content manipulation patch from @lacygoill
  Cleanups and an another "Can't change text here" bugfix
  Fix plugin for vim 8.2.2426 and 8.2.2427
  Add shortcut mapping to work in visual mode. (shawncplus#123)
  Fix for invalid index error when reading the variables from certain classes. (shawncplus#121)
  Fixed error messages displayed when extensions are missing. (shawncplus#120)
  Add filtering against functions removed since PHP 7.0.0 (shawncplus#119)
  Fix shawncplus#116 - jump to definition by tag line is not working
  Typofixes curtesy of Christ van Willegen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants