Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show color name #81

Merged
merged 2 commits into from
Sep 1, 2019
Merged

Show color name #81

merged 2 commits into from
Sep 1, 2019

Conversation

danieledapo
Copy link
Contributor

@danieledapo danieledapo commented Aug 30, 2019

Should close #77 .

After experimenting with this a bit, I believe that it's a bit more clear to have a dedicated "Name: " section vs making the color more visible in the "Most similar" list. But that's only my opinion.

Let me know what you think.

Screenshot:

@sharkdp
Copy link
Owner

sharkdp commented Sep 1, 2019

Thank you very much for your contribution. The changes look great.

@sharkdp sharkdp merged commit fdfaf9c into sharkdp:master Sep 1, 2019
@danieledapo danieledapo deleted the show-color-name branch September 1, 2019 07:51
@sharkdp
Copy link
Owner

sharkdp commented Sep 19, 2019

Released in v0.6.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show name if a given color has one
2 participants