Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show name if a given color has one #77

Closed
danieledapo opened this issue Aug 29, 2019 · 1 comment · Fixed by #81
Closed

Show name if a given color has one #77

danieledapo opened this issue Aug 29, 2019 · 1 comment · Fixed by #81
Labels
enhancement New feature or request

Comments

@danieledapo
Copy link
Contributor

As of now, pastel show ff0000 shows the following:

Screenshot from 2019-08-29 13-17-01

I think that it'd be useful to add a Name: section where to put the name of the color if it has one. Also, I think that hiding it from the most similar list makes sense because it is that color after all.

I have played around with this idea a bit and came up with

Screenshot from 2019-08-29 13-19-51

If you think that's something worth having then I'm happy to submit a PR, otherwise feel free to close this issue. Let me know what you think.

@sharkdp
Copy link
Owner

sharkdp commented Aug 29, 2019

Thank you for the feedback.

I have been thinking about a similar feature. From a "UI" perspective, an alternative would be to show a marker (e.g. *) after the color name or to highlight the "red" entry in the "Most similar" list. This way, the output would always have the same shape.

But I also like your suggestion. Showing only two entries in the "most similar" list - like in your screenshot - keeps the symmetry.

If you would like to experiment with this, I'd be happy to take a PR 👍

@sharkdp sharkdp added the enhancement New feature or request label Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants