Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cargo update #1284

Merged
merged 1 commit into from
Mar 20, 2023
Merged

Cargo update #1284

merged 1 commit into from
Mar 20, 2023

Conversation

tmccombs
Copy link
Collaborator

No description provided.

To update transient dependencies.

Notably, this removes fs_extras, the current version of which has code
that rustc identifies as not being future compatible.
@tavianator tavianator merged commit bae0a1b into sharkdp:master Mar 20, 2023
@tmccombs tmccombs deleted the cargo-update branch March 20, 2023 15:27
@sharkdp
Copy link
Owner

sharkdp commented Mar 21, 2023

Thank you. This seems to include the ignore update from #1250, which I would have liked to review in more detail.

Sure, we could always put all of our trust in the integration/regression tests that we have, but this dependency is so crucial for fd that I usually make an exception and at least scan the ChangeLog. @tmccombs What do you think?

@tmccombs
Copy link
Collaborator Author

Oh, I missed that it included that. I can look through the change log for it tonight. I'd also be ok reverting this merge until that has been reviewed more.

@sharkdp
Copy link
Owner

sharkdp commented Mar 22, 2023

I can look through the change log for it tonight.

No rush. I just commented because I suspected that it might have been an oversight. If you want to review the changelog, that would be very much appreciated. But I didn't want to suggest that it would have to be done by you.

@tavianator
Copy link
Collaborator

I reviewed the diff. Only things that stick out are

Looks fine to me. But yeah in the future I will check more carefully if ignore is updated :)

@sharkdp
Copy link
Owner

sharkdp commented Mar 22, 2023

Thank you. I guess this means we can close the other PR.

@tmccombs
Copy link
Collaborator Author

I looked through it to, and I didn't see anything else of note.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants