Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If require_git is false, don't stat .git #2052

Merged
merged 1 commit into from
Nov 12, 2021
Merged

If require_git is false, don't stat .git #2052

merged 1 commit into from
Nov 12, 2021

Conversation

joshtriplett
Copy link
Contributor

I've confirmed via strace that this eliminates a pile of stat calls.

BurntSushi
BurntSushi approved these changes Nov 9, 2021
View reviewed changes
Copy link
Owner

@BurntSushi BurntSushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think this just has to be rustfmt'd. :)

@joshtriplett
If require_git is false, don't stat .git
8f57bed 
I've confirmed via strace that this eliminates a pile of stat calls.
@joshtriplett joshtriplett force-pushed the dont-stat-git-if-not-requiring-git branch from c6442a6 to 8f57bed Compare November 11, 2021 12:49
@joshtriplett
Copy link
Contributor Author

rustfmt'd. :)

@BurntSushi BurntSushi merged commit 009dda1 into BurntSushi:master Nov 12, 2021
@tavianator tavianator mentioned this pull request Mar 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BurntSushi BurntSushi BurntSushi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshtriplett @BurntSushi