Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing goog.require() dependencies #420

Merged
merged 1 commit into from
Jun 26, 2016
Merged

Add missing goog.require() dependencies #420

merged 1 commit into from
Jun 26, 2016

Conversation

hochhaus
Copy link
Contributor

This change adds missing dependencies to shaka-player with the exception of adding 'shaka.offline.Storage' to 'shaka.offline.DownloadManager'. Doing so creates a circular dependency.

Checking the tests for type errors...
ERROR - Circular dependency detected: shaka.offline.Storage -> shaka.offline.DownloadManager -> shaka.offline.Storage

1 error(s), 0 warning(s)

I will look into resolving that circular dep in a dedicated change.

@hochhaus hochhaus mentioned this pull request Jun 25, 2016
Merged
@shaka-bot
Copy link
Collaborator

Testing in progress...

@joeyparrish
Copy link
Member

Thanks for the patch! Were these caught by the new compiler in #421?

@joeyparrish joeyparrish self-assigned this Jun 26, 2016
@shaka-bot
Copy link
Collaborator

All tests passed!

@joeyparrish joeyparrish merged commit 6a0f46c into shaka-project:master Jun 26, 2016
@hochhaus
Copy link
Contributor Author

Were these caught by the new compiler in #421?

Yes

@hochhaus hochhaus deleted the pr branch July 26, 2016 20:57
joeyparrish added a commit that referenced this pull request Mar 21, 2022
@joeyparrish
ci: Use simplified expression syntax (#4046)
218d05b 
The "if" fields do not need to use expression syntax (`${{ }}`), and
some conditionals will be easier to read if we omit that.

<!--
Please remember to:

1. Use Conventional Commits syntax (fix: ..., feat: ..., etc.) in commits and
   PR title (https://www.conventionalcommits.org/)
2. Tag any related or fixed issues ("Issue #123", "Closes #420")
3. Sign the Google CLA if you haven't (https://cla.developers.google.com)

You may delete this comment from the PR description.
-->
joeyparrish added a commit that referenced this pull request Mar 22, 2022
@joeyparrish
ci: Next release from main will be v4.0.0 (#4044)
8cd42ca 
This release-please config file is a temporary measure until our first
automated feature release from main.  So we have to explicitly state
the version number for this first release, and keep it up-to-date.

After the release, we should be able to remove this file and let the
workflow decide on version numbers automatically based on commit
messages.

<!--
Please remember to:

1. Use Conventional Commits syntax (fix: ..., feat: ..., etc.) in commits and
   PR title (https://www.conventionalcommits.org/)
2. Tag any related or fixed issues ("Issue #123", "Closes #420")
3. Sign the Google CLA if you haven't (https://cla.developers.google.com)

You may delete this comment from the PR description.
-->
joeyparrish added a commit that referenced this pull request Mar 22, 2022
@joeyparrish
ci: Use simplified expression syntax (#4046)
e5ffc9e 
The "if" fields do not need to use expression syntax (`${{ }}`), and
some conditionals will be easier to read if we omit that.

<!--
Please remember to:

1. Use Conventional Commits syntax (fix: ..., feat: ..., etc.) in commits and
   PR title (https://www.conventionalcommits.org/)
2. Tag any related or fixed issues ("Issue #123", "Closes #420")
3. Sign the Google CLA if you haven't (https://cla.developers.google.com)

You may delete this comment from the PR description.
-->
joeyparrish added a commit that referenced this pull request Mar 22, 2022
@joeyparrish
ci: Use simplified expression syntax (#4046)
cbb3daa 
The "if" fields do not need to use expression syntax (`${{ }}`), and
some conditionals will be easier to read if we omit that.

<!--
Please remember to:

1. Use Conventional Commits syntax (fix: ..., feat: ..., etc.) in commits and
   PR title (https://www.conventionalcommits.org/)
2. Tag any related or fixed issues ("Issue #123", "Closes #420")
3. Sign the Google CLA if you haven't (https://cla.developers.google.com)

You may delete this comment from the PR description.
-->
joeyparrish added a commit that referenced this pull request Mar 24, 2022
@joeyparrish
build: Fix build failure after Closure upgrade (#4063)
2c5457b 
6f274cb dropped a deprecated Closure build tool, but also upgraded
the Closure compiler and Closure library.  This introduced a failure
caused by a duplicate extern in the newer compiler.

This drops the now-unnecessary extern.

<!--
Please remember to:

1. Use Conventional Commits syntax (fix: ..., feat: ..., etc.) in commits and
   PR title (https://www.conventionalcommits.org/)
2. Tag any related or fixed issues ("Issue #123", "Closes #420")
3. Sign the Google CLA if you haven't (https://cla.developers.google.com)

You may delete this comment from the PR description.
-->
theodab added a commit that referenced this pull request Apr 11, 2022
@theodab
fix(demo): Fix default demo index versions (#4116)
fe8b9ab 
The script for deploying the demo version index page has a function
that chooses which versions to display. This script has a special
mode meant for testing that shows a default list of demo versions.
This mode was only supposed to trigger when run locally, but the
check did not work properly, so the demo version index was deploying
with a very out-of-date list of versions.
This fixes that check.

Closes #4074

<!--
Please remember to:

1. Use Conventional Commits syntax (fix: ..., feat: ..., etc.) in commits and
   PR title (https://www.conventionalcommits.org/)
2. Tag any related or fixed issues ("Issue #123", "Closes #420")
3. Sign the Google CLA if you haven't (https://cla.developers.google.com)

You may delete this comment from the PR description.
-->
joeyparrish pushed a commit that referenced this pull request Apr 21, 2022
@theodab @joeyparrish
fix(demo): Fix default demo index versions (#4116)
19c1e3c 
The script for deploying the demo version index page has a function
that chooses which versions to display. This script has a special
mode meant for testing that shows a default list of demo versions.
This mode was only supposed to trigger when run locally, but the
check did not work properly, so the demo version index was deploying
with a very out-of-date list of versions.
This fixes that check.

Closes #4074

<!--
Please remember to:

1. Use Conventional Commits syntax (fix: ..., feat: ..., etc.) in commits and
   PR title (https://www.conventionalcommits.org/)
2. Tag any related or fixed issues ("Issue #123", "Closes #420")
3. Sign the Google CLA if you haven't (https://cla.developers.google.com)

You may delete this comment from the PR description.
-->
avelad pushed a commit that referenced this pull request May 19, 2022
@theodab
feat(UI): Added keyboardSeekDistance config to UI (#4246)
6084ca6 
This new configuration value allows users to determine how far
the video seeks when you press the arrow keys on the video
element.

Closes #4245

<!--
Please remember to:

1. Use Conventional Commits syntax (fix: ..., feat: ..., etc.) in commits and
   PR title (https://www.conventionalcommits.org/)
2. Tag any related or fixed issues ("Issue #123", "Closes #420")
3. Sign the Google CLA if you haven't (https://cla.developers.google.com)

You may delete this comment from the PR description.
-->
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@joeyparrish joeyparrish

Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hochhaus @shaka-bot @joeyparrish