Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Fix build failure after Closure upgrade #4063

Merged
merged 1 commit into from
Mar 24, 2022

Conversation

joeyparrish
Copy link
Member

6f274cb dropped a deprecated Closure build tool, but also upgraded
the Closure compiler and Closure library. This introduced a failure
caused by a duplicate extern in the newer compiler.

This drops the now-unnecessary extern.

6f274cb dropped a deprecated Closure build tool, but also upgraded
the Closure compiler and Closure library.  This introduced a failure
caused by a duplicate extern in the newer compiler.

This drops the now-unnecessary extern.
@joeyparrish joeyparrish merged commit 2c5457b into shaka-project:main Mar 24, 2022
@joeyparrish joeyparrish deleted the fix-build-failure branch March 24, 2022 22:01
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants